Preserve API backward compatibility

This commit is contained in:
John Starich 2020-04-25 14:14:42 -05:00
parent 15c75690fc
commit 36d8d881f9
3 changed files with 7 additions and 3 deletions

View File

@ -101,7 +101,11 @@ var DefaultExcludePatterns = []ExcludePattern{
},
}
func GetDefaultExcludePatternsStrings(include []string) []string {
func GetDefaultExcludePatternsStrings() []string {
return GetExcludePatternsStrings(nil)
}
func GetExcludePatternsStrings(include []string) []string {
includeMap := make(map[string]bool, len(include))
for _, inc := range include {
includeMap[inc] = true

View File

@ -32,7 +32,7 @@ func NewRunner(cfg *config.Config, log logutils.Log, goenv *goutil.Env,
icfg := cfg.Issues
excludePatterns := icfg.ExcludePatterns
if icfg.UseDefaultExcludes {
excludePatterns = append(excludePatterns, config.GetDefaultExcludePatternsStrings(icfg.IncludeDefaultExcludes)...)
excludePatterns = append(excludePatterns, config.GetExcludePatternsStrings(icfg.IncludeDefaultExcludes)...)
}
var excludeTotalPattern string

View File

@ -77,7 +77,7 @@ func getGometalinterCommonArgs() []string {
"--vendor",
"--cyclo-over=30",
"--dupl-threshold=150",
"--exclude", fmt.Sprintf("(%s)", strings.Join(config.GetDefaultExcludePatternsStrings(nil), "|")),
"--exclude", fmt.Sprintf("(%s)", strings.Join(config.GetDefaultExcludePatternsStrings(), "|")),
"--disable-all",
"--enable=vet",
"--enable=vetshadow",