
$ git cherry --abbrev -v 8afd9cbb6cfb 66fb7fc33547 + 63b25c1 Fix typo in README (#235) + 419c929 G107 - SSRF (#236) + 145f1a0 Removed wrapping feature (#238) + ec32ce6 Support Go 1.11 (#239) + 762ff3a Allow quoted strings to be used to format SQL queries (#240) + 7f6509a Update README.md (#246) + 5f98926 Refactor Dockerfile (#245) + d3f1980 Fix false positives for SQL string concatenation with constants from another file (#247) + 64d58c2 Refactor the test code sample to support multiple files per sample + 1ecd47e bump Dockerfile golang from 1.10 to 1.11 + 027dc2b This fixes the html template when using '-fmt=html' - resolves HTML escaping issues within the template - resolves reference issues to reportInfo struct i.e. issues -> Issues, metrics -> Stats + 8c09a83 Add install.sh script + 97bc137 Add CI Installation steps and correct markdown lint errors + 3116b07 Fix typos in comments and rulelist (#256) + 443f84f Fix golint link (#263) + 4180994 Make G201 ignore CallExpr with no args (#262) + 9b966a4 add test case for strings.Builder G104 whitelist inclusion + adb4222 whitelist strings.Builder method in rule G104 + ae82798 Fix the WriteSring test by handling the error + 2695567 Build the code sample for string builder only fron Go 1.10 onwards + f14f17f Add a helper function which extracts the string parameters values of a call expression + 9b32fca Fix the bind rule to handle the case when the arguments of the net.Listen are returned by a function call + 24e3094 Extend the bind rule to handle the case when the net.Listen address in provided from a const + 72e95e8 Geneate and upload the test coverage report to codecove.io + 12400f9 Update README with the code coverage batch + 14ed63d Do not flag the unhandled errors which are explicitly ignored + f87af5f Detect the unhandled errors even though they are explicitly ignored if the 'audit: enabled' setting is defined in the global configuration (#274) + 5d33e6e Update the README with some details about the configuration file + b662615 Fix typo + a966ff7 Fix -conf example in README.md + 04ce7ba add a no-fail flag + e2752bc revert to default GOPATH if necessary (#279) - c04360f make API + 66fb7fc Replace import paths
123 lines
3.3 KiB
Go
123 lines
3.3 KiB
Go
// (c) Copyright 2016 Hewlett Packard Enterprise Development LP
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package gosec
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"go/ast"
|
|
"os"
|
|
"strconv"
|
|
)
|
|
|
|
// Score type used by severity and confidence values
|
|
type Score int
|
|
|
|
const (
|
|
// Low severity or confidence
|
|
Low Score = iota
|
|
// Medium severity or confidence
|
|
Medium
|
|
// High severity or confidence
|
|
High
|
|
)
|
|
|
|
// Issue is returned by a gosec rule if it discovers an issue with the scanned code.
|
|
type Issue struct {
|
|
Severity Score `json:"severity"` // issue severity (how problematic it is)
|
|
Confidence Score `json:"confidence"` // issue confidence (how sure we are we found it)
|
|
RuleID string `json:"rule_id"` // Human readable explanation
|
|
What string `json:"details"` // Human readable explanation
|
|
File string `json:"file"` // File name we found it in
|
|
Code string `json:"code"` // Impacted code line
|
|
Line string `json:"line"` // Line number in file
|
|
}
|
|
|
|
// MetaData is embedded in all gosec rules. The Severity, Confidence and What message
|
|
// will be passed through to reported issues.
|
|
type MetaData struct {
|
|
ID string
|
|
Severity Score
|
|
Confidence Score
|
|
What string
|
|
}
|
|
|
|
// MarshalJSON is used convert a Score object into a JSON representation
|
|
func (c Score) MarshalJSON() ([]byte, error) {
|
|
return json.Marshal(c.String())
|
|
}
|
|
|
|
// String converts a Score into a string
|
|
func (c Score) String() string {
|
|
switch c {
|
|
case High:
|
|
return "HIGH"
|
|
case Medium:
|
|
return "MEDIUM"
|
|
case Low:
|
|
return "LOW"
|
|
}
|
|
return "UNDEFINED"
|
|
}
|
|
|
|
func codeSnippet(file *os.File, start int64, end int64, n ast.Node) (string, error) {
|
|
if n == nil {
|
|
return "", fmt.Errorf("Invalid AST node provided")
|
|
}
|
|
|
|
size := (int)(end - start) // Go bug, os.File.Read should return int64 ...
|
|
file.Seek(start, 0) // #nosec
|
|
|
|
buf := make([]byte, size)
|
|
if nread, err := file.Read(buf); err != nil || nread != size {
|
|
return "", fmt.Errorf("Unable to read code")
|
|
}
|
|
return string(buf), nil
|
|
}
|
|
|
|
// NewIssue creates a new Issue
|
|
func NewIssue(ctx *Context, node ast.Node, ruleID, desc string, severity Score, confidence Score) *Issue {
|
|
var code string
|
|
fobj := ctx.FileSet.File(node.Pos())
|
|
name := fobj.Name()
|
|
|
|
start, end := fobj.Line(node.Pos()), fobj.Line(node.End())
|
|
line := strconv.Itoa(start)
|
|
if start != end {
|
|
line = fmt.Sprintf("%d-%d", start, end)
|
|
}
|
|
|
|
// #nosec
|
|
if file, err := os.Open(fobj.Name()); err == nil {
|
|
defer file.Close()
|
|
s := (int64)(fobj.Position(node.Pos()).Offset) // Go bug, should be int64
|
|
e := (int64)(fobj.Position(node.End()).Offset) // Go bug, should be int64
|
|
code, err = codeSnippet(file, s, e, node)
|
|
if err != nil {
|
|
code = err.Error()
|
|
}
|
|
}
|
|
|
|
return &Issue{
|
|
File: name,
|
|
Line: line,
|
|
RuleID: ruleID,
|
|
What: desc,
|
|
Confidence: confidence,
|
|
Severity: severity,
|
|
Code: code,
|
|
}
|
|
}
|