 bf27481efd
			
		
	
	
		bf27481efd
		
			
		
	
	
	
	
		
			
			full diff: https://github.com/dominikh/go-tools/compare/2019.2.3...2020.1.3 Also updates tests to accomodate updated rules: --- FAIL: TestSourcesFromTestdataWithIssuesDir/staticcheck.go (0.43s) linters_test.go:137: [run --disable-all --print-issued-lines=false --print-linter-name=false --out-format=line-number --max-same-issues=10 -Estaticcheck --no-config testdata/staticcheck.go] linters_test.go:33: Error Trace: linters_test.go:33 linters_test.go:138 linters_test.go:53 Error: Received unexpected error: staticcheck.go:11: no match for `self-assignment of x to x` vs ["SA4006: this value of `x` is never used"] in: staticcheck.go:11:2: SA4006: this value of `x` is never used unmatched errors staticcheck.go:11:2: SA4006: this value of `x` is never used Test: TestSourcesFromTestdataWithIssuesDir/staticcheck.go Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
		
			
				
	
	
		
			55 lines
		
	
	
		
			1.0 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			55 lines
		
	
	
		
			1.0 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package functions
 | |
| 
 | |
| import "honnef.co/go/tools/ir"
 | |
| 
 | |
| type Loop struct{ *ir.BlockSet }
 | |
| 
 | |
| func FindLoops(fn *ir.Function) []Loop {
 | |
| 	if fn.Blocks == nil {
 | |
| 		return nil
 | |
| 	}
 | |
| 	tree := fn.DomPreorder()
 | |
| 	var sets []Loop
 | |
| 	for _, h := range tree {
 | |
| 		for _, n := range h.Preds {
 | |
| 			if !h.Dominates(n) {
 | |
| 				continue
 | |
| 			}
 | |
| 			// n is a back-edge to h
 | |
| 			// h is the loop header
 | |
| 			if n == h {
 | |
| 				set := Loop{ir.NewBlockSet(len(fn.Blocks))}
 | |
| 				set.Add(n)
 | |
| 				sets = append(sets, set)
 | |
| 				continue
 | |
| 			}
 | |
| 			set := Loop{ir.NewBlockSet(len(fn.Blocks))}
 | |
| 			set.Add(h)
 | |
| 			set.Add(n)
 | |
| 			for _, b := range allPredsBut(n, h, nil) {
 | |
| 				set.Add(b)
 | |
| 			}
 | |
| 			sets = append(sets, set)
 | |
| 		}
 | |
| 	}
 | |
| 	return sets
 | |
| }
 | |
| 
 | |
| func allPredsBut(b, but *ir.BasicBlock, list []*ir.BasicBlock) []*ir.BasicBlock {
 | |
| outer:
 | |
| 	for _, pred := range b.Preds {
 | |
| 		if pred == but {
 | |
| 			continue
 | |
| 		}
 | |
| 		for _, p := range list {
 | |
| 			// TODO improve big-o complexity of this function
 | |
| 			if pred == p {
 | |
| 				continue outer
 | |
| 			}
 | |
| 		}
 | |
| 		list = append(list, pred)
 | |
| 		list = allPredsBut(pred, but, list)
 | |
| 	}
 | |
| 	return list
 | |
| }
 |