bf27481efd
full diff: https://github.com/dominikh/go-tools/compare/2019.2.3...2020.1.3 Also updates tests to accomodate updated rules: --- FAIL: TestSourcesFromTestdataWithIssuesDir/staticcheck.go (0.43s) linters_test.go:137: [run --disable-all --print-issued-lines=false --print-linter-name=false --out-format=line-number --max-same-issues=10 -Estaticcheck --no-config testdata/staticcheck.go] linters_test.go:33: Error Trace: linters_test.go:33 linters_test.go:138 linters_test.go:53 Error: Received unexpected error: staticcheck.go:11: no match for `self-assignment of x to x` vs ["SA4006: this value of `x` is never used"] in: staticcheck.go:11:2: SA4006: this value of `x` is never used unmatched errors staticcheck.go:11:2: SA4006: this value of `x` is never used Test: TestSourcesFromTestdataWithIssuesDir/staticcheck.go Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
68 lines
1.4 KiB
Go
68 lines
1.4 KiB
Go
package edit
|
|
|
|
import (
|
|
"bytes"
|
|
"go/ast"
|
|
"go/format"
|
|
"go/token"
|
|
|
|
"golang.org/x/tools/go/analysis"
|
|
"honnef.co/go/tools/pattern"
|
|
)
|
|
|
|
type Ranger interface {
|
|
Pos() token.Pos
|
|
End() token.Pos
|
|
}
|
|
|
|
type Range [2]token.Pos
|
|
|
|
func (r Range) Pos() token.Pos { return r[0] }
|
|
func (r Range) End() token.Pos { return r[1] }
|
|
|
|
func ReplaceWithString(fset *token.FileSet, old Ranger, new string) analysis.TextEdit {
|
|
return analysis.TextEdit{
|
|
Pos: old.Pos(),
|
|
End: old.End(),
|
|
NewText: []byte(new),
|
|
}
|
|
}
|
|
|
|
func ReplaceWithNode(fset *token.FileSet, old Ranger, new ast.Node) analysis.TextEdit {
|
|
buf := &bytes.Buffer{}
|
|
if err := format.Node(buf, fset, new); err != nil {
|
|
panic("internal error: " + err.Error())
|
|
}
|
|
return analysis.TextEdit{
|
|
Pos: old.Pos(),
|
|
End: old.End(),
|
|
NewText: buf.Bytes(),
|
|
}
|
|
}
|
|
|
|
func ReplaceWithPattern(pass *analysis.Pass, after pattern.Pattern, state pattern.State, node Ranger) analysis.TextEdit {
|
|
r := pattern.NodeToAST(after.Root, state)
|
|
buf := &bytes.Buffer{}
|
|
format.Node(buf, pass.Fset, r)
|
|
return analysis.TextEdit{
|
|
Pos: node.Pos(),
|
|
End: node.End(),
|
|
NewText: buf.Bytes(),
|
|
}
|
|
}
|
|
|
|
func Delete(old Ranger) analysis.TextEdit {
|
|
return analysis.TextEdit{
|
|
Pos: old.Pos(),
|
|
End: old.End(),
|
|
NewText: nil,
|
|
}
|
|
}
|
|
|
|
func Fix(msg string, edits ...analysis.TextEdit) analysis.SuggestedFix {
|
|
return analysis.SuggestedFix{
|
|
Message: msg,
|
|
TextEdits: edits,
|
|
}
|
|
}
|