150 lines
3.6 KiB
Go
150 lines
3.6 KiB
Go
package processors
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"sort"
|
|
"strings"
|
|
|
|
"github.com/golangci/golangci-lint/pkg/logutils"
|
|
|
|
"github.com/pkg/errors"
|
|
|
|
"github.com/golangci/golangci-lint/pkg/config"
|
|
"github.com/golangci/golangci-lint/pkg/result"
|
|
)
|
|
|
|
type Fixer struct {
|
|
cfg *config.Config
|
|
log logutils.Log
|
|
}
|
|
|
|
func NewFixer(cfg *config.Config, log logutils.Log) *Fixer {
|
|
return &Fixer{cfg: cfg, log: log}
|
|
}
|
|
|
|
func (f Fixer) Process(issues <-chan result.Issue) <-chan result.Issue {
|
|
if !f.cfg.Issues.NeedFix {
|
|
return issues
|
|
}
|
|
|
|
outCh := make(chan result.Issue, 1024)
|
|
|
|
go func() {
|
|
issuesToFixPerFile := map[string][]result.Issue{}
|
|
for issue := range issues {
|
|
if issue.Replacement == nil {
|
|
outCh <- issue
|
|
continue
|
|
}
|
|
|
|
issuesToFixPerFile[issue.FilePath()] = append(issuesToFixPerFile[issue.FilePath()], issue)
|
|
}
|
|
|
|
for file, issuesToFix := range issuesToFixPerFile {
|
|
if err := f.fixIssuesInFile(file, issuesToFix); err != nil {
|
|
f.log.Errorf("Failed to fix issues in file %s: %s", file, err)
|
|
|
|
// show issues only if can't fix them
|
|
for _, issue := range issuesToFix {
|
|
outCh <- issue
|
|
}
|
|
}
|
|
}
|
|
close(outCh)
|
|
}()
|
|
|
|
return outCh
|
|
}
|
|
|
|
func (f Fixer) fixIssuesInFile(filePath string, issues []result.Issue) error {
|
|
// TODO: don't read the whole file into memory: read line by line;
|
|
// can't just use bufio.scanner: it has a line length limit
|
|
origFileData, err := ioutil.ReadFile(filePath)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "failed to read %s", filePath)
|
|
}
|
|
origFileLines := bytes.Split(origFileData, []byte("\n"))
|
|
|
|
tmpFileName := filepath.Join(filepath.Dir(filePath), fmt.Sprintf(".%s.golangci_fix", filepath.Base(filePath)))
|
|
tmpOutFile, err := os.Create(tmpFileName)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "failed to make file %s", tmpFileName)
|
|
}
|
|
|
|
issues = f.findNotIntersectingIssues(issues)
|
|
|
|
if err = f.writeFixedFile(origFileLines, issues, tmpOutFile); err != nil {
|
|
tmpOutFile.Close()
|
|
os.Remove(tmpOutFile.Name())
|
|
return err
|
|
}
|
|
|
|
tmpOutFile.Close()
|
|
if err = os.Rename(tmpOutFile.Name(), filePath); err != nil {
|
|
os.Remove(tmpOutFile.Name())
|
|
return errors.Wrapf(err, "failed to rename %s -> %s", tmpOutFile.Name(), filePath)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (f Fixer) findNotIntersectingIssues(issues []result.Issue) []result.Issue {
|
|
sort.SliceStable(issues, func(i, j int) bool {
|
|
return issues[i].Line() < issues[j].Line() //nolint:scopelint
|
|
})
|
|
|
|
var ret []result.Issue
|
|
var currentEnd int
|
|
for _, issue := range issues {
|
|
rng := issue.GetLineRange()
|
|
if rng.From <= currentEnd {
|
|
f.log.Infof("Skip issue %#v: intersects with end %d", issue, currentEnd)
|
|
continue // skip intersecting issue
|
|
}
|
|
f.log.Infof("Fix issue %#v with range %v", issue, issue.GetLineRange())
|
|
ret = append(ret, issue)
|
|
currentEnd = rng.To
|
|
}
|
|
|
|
return ret
|
|
}
|
|
|
|
func (f Fixer) writeFixedFile(origFileLines [][]byte, issues []result.Issue, tmpOutFile *os.File) error {
|
|
// issues aren't intersecting
|
|
|
|
nextIssueIndex := 0
|
|
for i := 0; i < len(origFileLines); i++ {
|
|
var outLine string
|
|
var nextIssue *result.Issue
|
|
if nextIssueIndex != len(issues) {
|
|
nextIssue = &issues[nextIssueIndex]
|
|
}
|
|
|
|
origFileLineNumber := i + 1
|
|
if nextIssue == nil || origFileLineNumber != nextIssue.Line() {
|
|
outLine = string(origFileLines[i])
|
|
} else {
|
|
nextIssueIndex++
|
|
rng := nextIssue.GetLineRange()
|
|
i += rng.To - rng.From
|
|
if nextIssue.Replacement.NeedOnlyDelete {
|
|
continue
|
|
}
|
|
outLine = strings.Join(nextIssue.Replacement.NewLines, "\n")
|
|
}
|
|
|
|
if i < len(origFileLines)-1 {
|
|
outLine += "\n"
|
|
}
|
|
if _, err := tmpOutFile.WriteString(outLine); err != nil {
|
|
return errors.Wrap(err, "failed to write output line")
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|