
Also do following improvements: - show proper sublinter name for megacheck sublinters - refactor and make more simple and robust megacheck merging/optimizing - improve handling of unknown linter names in //nolint directives - minimize diff of our megacheck version from the upstream, https://github.com/golang/go/issues/29612 blocks usage of the upstream version - support the new `stylecheck` linter - improve tests coverage for megacheck and nolint related cases - update and use upstream versions of unparam and interfacer instead of forked ones - don't use golangci/tools repo anymore - fix newly found issues after updating linters Also should be noted that megacheck works much faster and consumes less memory in the newest release, therefore golangci-lint works noticeably faster and consumes less memory for large repos. Relates: #314
51 lines
969 B
Go
51 lines
969 B
Go
package functions
|
|
|
|
import "github.com/golangci/go-tools/ssa"
|
|
|
|
type Loop map[*ssa.BasicBlock]bool
|
|
|
|
func findLoops(fn *ssa.Function) []Loop {
|
|
if fn.Blocks == nil {
|
|
return nil
|
|
}
|
|
tree := fn.DomPreorder()
|
|
var sets []Loop
|
|
for _, h := range tree {
|
|
for _, n := range h.Preds {
|
|
if !h.Dominates(n) {
|
|
continue
|
|
}
|
|
// n is a back-edge to h
|
|
// h is the loop header
|
|
if n == h {
|
|
sets = append(sets, Loop{n: true})
|
|
continue
|
|
}
|
|
set := Loop{h: true, n: true}
|
|
for _, b := range allPredsBut(n, h, nil) {
|
|
set[b] = true
|
|
}
|
|
sets = append(sets, set)
|
|
}
|
|
}
|
|
return sets
|
|
}
|
|
|
|
func allPredsBut(b, but *ssa.BasicBlock, list []*ssa.BasicBlock) []*ssa.BasicBlock {
|
|
outer:
|
|
for _, pred := range b.Preds {
|
|
if pred == but {
|
|
continue
|
|
}
|
|
for _, p := range list {
|
|
// TODO improve big-o complexity of this function
|
|
if pred == p {
|
|
continue outer
|
|
}
|
|
}
|
|
list = append(list, pred)
|
|
list = allPredsBut(pred, but, list)
|
|
}
|
|
return list
|
|
}
|