87aae77943
Fix #324, relates #314 1. Update gocritic to the latest version 2. Use proper gocritic checkers repo, old repo was archived 3. Get enabled by default gocritic checks in sync with go-critic: don't enable performance, experimental and opinionated checks by default 4. Support of `enabled-tags` options for gocritic 5. Enable almost all gocritic checks for the project 6. Make rich debugging for gocritic 7. Meticulously validate gocritic checks config
70 lines
1.6 KiB
Go
70 lines
1.6 KiB
Go
package checkers
|
|
|
|
import (
|
|
"go/ast"
|
|
"go/token"
|
|
|
|
"github.com/go-lintpack/lintpack"
|
|
"github.com/go-lintpack/lintpack/astwalk"
|
|
)
|
|
|
|
func init() {
|
|
var info lintpack.CheckerInfo
|
|
info.Name = "unnecessaryBlock"
|
|
info.Tags = []string{"style", "opinionated", "experimental"}
|
|
info.Summary = "Detects unnecessary braced statement blocks"
|
|
info.Before = `
|
|
x := 1
|
|
{
|
|
print(x)
|
|
}`
|
|
info.After = `
|
|
x := 1
|
|
print(x)`
|
|
|
|
collection.AddChecker(&info, func(ctx *lintpack.CheckerContext) lintpack.FileWalker {
|
|
return astwalk.WalkerForStmtList(&unnecessaryBlockChecker{ctx: ctx})
|
|
})
|
|
}
|
|
|
|
type unnecessaryBlockChecker struct {
|
|
astwalk.WalkHandler
|
|
ctx *lintpack.CheckerContext
|
|
}
|
|
|
|
func (c *unnecessaryBlockChecker) VisitStmtList(statements []ast.Stmt) {
|
|
// Using StmtListVisitor instead of StmtVisitor makes it easier to avoid
|
|
// false positives on IfStmt, RangeStmt, ForStmt and alike.
|
|
// We only inspect BlockStmt inside statement lists, so this method is not
|
|
// called for IfStmt itself, for example.
|
|
|
|
for _, stmt := range statements {
|
|
stmt, ok := stmt.(*ast.BlockStmt)
|
|
if ok && !c.hasDefinitions(stmt) {
|
|
c.warn(stmt)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (c *unnecessaryBlockChecker) hasDefinitions(stmt *ast.BlockStmt) bool {
|
|
for _, bs := range stmt.List {
|
|
switch stmt := bs.(type) {
|
|
case *ast.AssignStmt:
|
|
if stmt.Tok == token.DEFINE {
|
|
return true
|
|
}
|
|
case *ast.DeclStmt:
|
|
decl := stmt.Decl.(*ast.GenDecl)
|
|
if len(decl.Specs) != 0 {
|
|
return true
|
|
}
|
|
}
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
func (c *unnecessaryBlockChecker) warn(expr ast.Stmt) {
|
|
c.ctx.Warn(expr, "block doesn't have definitions, can be simply deleted")
|
|
}
|