183765e6d4
$ git cherry --abbrev -v 8afd9cbb6cfb 66fb7fc33547 + 63b25c1 Fix typo in README (#235) + 419c929 G107 - SSRF (#236) + 145f1a0 Removed wrapping feature (#238) + ec32ce6 Support Go 1.11 (#239) + 762ff3a Allow quoted strings to be used to format SQL queries (#240) + 7f6509a Update README.md (#246) + 5f98926 Refactor Dockerfile (#245) + d3f1980 Fix false positives for SQL string concatenation with constants from another file (#247) + 64d58c2 Refactor the test code sample to support multiple files per sample + 1ecd47e bump Dockerfile golang from 1.10 to 1.11 + 027dc2b This fixes the html template when using '-fmt=html' - resolves HTML escaping issues within the template - resolves reference issues to reportInfo struct i.e. issues -> Issues, metrics -> Stats + 8c09a83 Add install.sh script + 97bc137 Add CI Installation steps and correct markdown lint errors + 3116b07 Fix typos in comments and rulelist (#256) + 443f84f Fix golint link (#263) + 4180994 Make G201 ignore CallExpr with no args (#262) + 9b966a4 add test case for strings.Builder G104 whitelist inclusion + adb4222 whitelist strings.Builder method in rule G104 + ae82798 Fix the WriteSring test by handling the error + 2695567 Build the code sample for string builder only fron Go 1.10 onwards + f14f17f Add a helper function which extracts the string parameters values of a call expression + 9b32fca Fix the bind rule to handle the case when the arguments of the net.Listen are returned by a function call + 24e3094 Extend the bind rule to handle the case when the net.Listen address in provided from a const + 72e95e8 Geneate and upload the test coverage report to codecove.io + 12400f9 Update README with the code coverage batch + 14ed63d Do not flag the unhandled errors which are explicitly ignored + f87af5f Detect the unhandled errors even though they are explicitly ignored if the 'audit: enabled' setting is defined in the global configuration (#274) + 5d33e6e Update the README with some details about the configuration file + b662615 Fix typo + a966ff7 Fix -conf example in README.md + 04ce7ba add a no-fail flag + e2752bc revert to default GOPATH if necessary (#279) - c04360f make API + 66fb7fc Replace import paths
61 lines
1.6 KiB
Go
61 lines
1.6 KiB
Go
package rules
|
|
|
|
import (
|
|
"go/ast"
|
|
"go/types"
|
|
|
|
"github.com/golangci/gosec"
|
|
)
|
|
|
|
type archive struct {
|
|
gosec.MetaData
|
|
calls gosec.CallList
|
|
argType string
|
|
}
|
|
|
|
func (a *archive) ID() string {
|
|
return a.MetaData.ID
|
|
}
|
|
|
|
// Match inspects AST nodes to determine if the filepath.Joins uses any argument derived from type zip.File
|
|
func (a *archive) Match(n ast.Node, c *gosec.Context) (*gosec.Issue, error) {
|
|
if node := a.calls.ContainsCallExpr(n, c, false); node != nil {
|
|
for _, arg := range node.Args {
|
|
var argType types.Type
|
|
if selector, ok := arg.(*ast.SelectorExpr); ok {
|
|
argType = c.Info.TypeOf(selector.X)
|
|
} else if ident, ok := arg.(*ast.Ident); ok {
|
|
if ident.Obj != nil && ident.Obj.Kind == ast.Var {
|
|
decl := ident.Obj.Decl
|
|
if assign, ok := decl.(*ast.AssignStmt); ok {
|
|
if selector, ok := assign.Rhs[0].(*ast.SelectorExpr); ok {
|
|
argType = c.Info.TypeOf(selector.X)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
if argType != nil && argType.String() == a.argType {
|
|
return gosec.NewIssue(c, n, a.ID(), a.What, a.Severity, a.Confidence), nil
|
|
}
|
|
}
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
// NewArchive creates a new rule which detects the file traversal when extracting zip archives
|
|
func NewArchive(id string, conf gosec.Config) (gosec.Rule, []ast.Node) {
|
|
calls := gosec.NewCallList()
|
|
calls.Add("path/filepath", "Join")
|
|
return &archive{
|
|
calls: calls,
|
|
argType: "*archive/zip.File",
|
|
MetaData: gosec.MetaData{
|
|
ID: id,
|
|
Severity: gosec.Medium,
|
|
Confidence: gosec.High,
|
|
What: "File traversal when extracting zip archive",
|
|
},
|
|
}, []ast.Node{(*ast.CallExpr)(nil)}
|
|
}
|