Load AST for fast linters in different way.

Use build.Import instead of manual parser.ParseFile and paths traversal. It allows:
1. support build tags for all linters.
2. analyze files only for current GOOS/GOARCH: less false-positives.
3. analyze xtest packages (*_test) by golint: upstream golint and
gometalinter can't do it! And don't break analysis on the first xtest
package like it was before.
4. proper handling of xtest packages for linters like goconst where
package boundary is important: less false-positives is expected.

Also:
1. reuse AST parsing for golint and goconst: minor speedup.
2. allow to specify path (not only name) regexp for --skip-files and
--skip-dirs
3. add more default exclude filters for golint about commits:
`(comment on exported (method|function)|should have( a package)?
    comment|comment should be of the form)`
4. print skipped dir in verbose (-v) mode
5. refactor per-linter tests: declare arguments in comments, run only
one linter and in combination with slow linter

2018-06-10 23:46:24 +03:00

412 B

Raw Blame History

Contributing to Golint

Before filing an issue:

Are you having trouble building golint?

Check you have the latest version of its dependencies. Run

go get -u golang.org/x/lint/golint

If you still have problems, consider searching for existing issues before filing a new issue.

Before sending a pull request:

Have you understood the purpose of golint? Make sure to carefully read README.

412 B Raw Blame History

Contributing to Golint

Before filing an issue:

Are you having trouble building golint?

Before sending a pull request:

412 B

Raw Blame History