9181ca7175
1. Log all warnings, don't hide none of them 2. Write fatal messages (stop analysis) with error log level 3. Remove ugly timestamp counter from logrus output 4. Print nested module prefix in log 5. Make logger abstraction: no global logging anymore 6. Refactor config reading to config.FileReader struct to avoid passing logger into every function 7. Replace exit codes hardcoding with constants in exitcodes package 8. Fail test if any warning was logged 9. Fix calculation of relative path if we analyze parent dir ../ 10. Move Runner initialization from Executor to NewRunner func 11. Log every AST parsing error 12. Properly print used config file path in verbose mode 13. Print package files if only 1 package is analyzedin verbose mode, print not compiling packages in verbose mode 14. Forbid usage of github.com/sirupsen/logrus by DepGuard linter 15. Add default ignore pattern to folint: "comment on exported const"
139 lines
3.7 KiB
Go
139 lines
3.7 KiB
Go
package processors
|
|
|
|
import (
|
|
"go/token"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/golangci/golangci-lint/pkg/lint/astcache"
|
|
"github.com/golangci/golangci-lint/pkg/logutils"
|
|
"github.com/golangci/golangci-lint/pkg/result"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func newNolintFileIssue(line int, fromLinter string) result.Issue {
|
|
return result.Issue{
|
|
Pos: token.Position{
|
|
Filename: filepath.Join("testdata", "nolint.go"),
|
|
Line: line,
|
|
},
|
|
FromLinter: fromLinter,
|
|
}
|
|
}
|
|
|
|
func TestNolint(t *testing.T) {
|
|
p := NewNolint(astcache.NewCache(logutils.NewStderrLog("")))
|
|
|
|
// test inline comments
|
|
processAssertEmpty(t, p, newNolintFileIssue(3, "gofmt"))
|
|
processAssertEmpty(t, p, newNolintFileIssue(3, "gofmt")) // check cached is ok
|
|
processAssertSame(t, p, newNolintFileIssue(3, "gofmtA")) // check different name
|
|
|
|
processAssertEmpty(t, p, newNolintFileIssue(4, "gofmt"))
|
|
processAssertSame(t, p, newNolintFileIssue(4, "gofmtA")) // check different name
|
|
|
|
processAssertEmpty(t, p, newNolintFileIssue(5, "gofmt"))
|
|
processAssertEmpty(t, p, newNolintFileIssue(5, "govet"))
|
|
processAssertSame(t, p, newNolintFileIssue(5, "gofmtA")) // check different name
|
|
|
|
processAssertEmpty(t, p, newNolintFileIssue(6, "any"))
|
|
processAssertEmpty(t, p, newNolintFileIssue(7, "any"))
|
|
|
|
processAssertSame(t, p, newNolintFileIssue(1, "golint")) // no directive
|
|
|
|
// test preceding comments
|
|
processAssertEmpty(t, p, newNolintFileIssue(10, "any")) // preceding comment for var
|
|
processAssertEmpty(t, p, newNolintFileIssue(9, "any")) // preceding comment for var itself
|
|
|
|
processAssertSame(t, p, newNolintFileIssue(14, "any")) // preceding comment with extra \n
|
|
processAssertEmpty(t, p, newNolintFileIssue(12, "any")) // preceding comment with extra \n itself
|
|
|
|
processAssertSame(t, p, newNolintFileIssue(17, "any")) // preceding comment on different column
|
|
processAssertEmpty(t, p, newNolintFileIssue(16, "any")) // preceding comment on different column itself
|
|
|
|
// preceding comment for func name and comment itself
|
|
for i := 19; i <= 23; i++ {
|
|
processAssertEmpty(t, p, newNolintFileIssue(i, "any"))
|
|
}
|
|
|
|
processAssertSame(t, p, newNolintFileIssue(24, "any")) // right after func
|
|
|
|
// preceding multiline comment: last line
|
|
for i := 25; i <= 30; i++ {
|
|
processAssertEmpty(t, p, newNolintFileIssue(i, "any"))
|
|
}
|
|
|
|
processAssertSame(t, p, newNolintFileIssue(31, "any")) // between funcs
|
|
|
|
// preceding multiline comment: first line
|
|
for i := 32; i <= 37; i++ {
|
|
processAssertEmpty(t, p, newNolintFileIssue(i, "any"))
|
|
}
|
|
|
|
processAssertSame(t, p, newNolintFileIssue(38, "any")) // between funcs
|
|
|
|
// preceding multiline comment: medium line
|
|
for i := 39; i <= 45; i++ {
|
|
processAssertEmpty(t, p, newNolintFileIssue(i, "any"))
|
|
}
|
|
}
|
|
|
|
func TestIgnoredRangeMatches(t *testing.T) {
|
|
var testcases = []struct {
|
|
doc string
|
|
issue result.Issue
|
|
linters []string
|
|
expected bool
|
|
}{
|
|
{
|
|
doc: "unmatched line",
|
|
issue: result.Issue{
|
|
Pos: token.Position{
|
|
Line: 100,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
doc: "matched line, all linters",
|
|
issue: result.Issue{
|
|
Pos: token.Position{
|
|
Line: 5,
|
|
},
|
|
},
|
|
expected: true,
|
|
},
|
|
{
|
|
doc: "matched line, unmatched linter",
|
|
issue: result.Issue{
|
|
Pos: token.Position{
|
|
Line: 5,
|
|
},
|
|
},
|
|
linters: []string{"vet"},
|
|
},
|
|
{
|
|
doc: "matched line and linters",
|
|
issue: result.Issue{
|
|
Pos: token.Position{
|
|
Line: 20,
|
|
},
|
|
FromLinter: "vet",
|
|
},
|
|
linters: []string{"vet"},
|
|
expected: true,
|
|
},
|
|
}
|
|
|
|
for _, testcase := range testcases {
|
|
ir := ignoredRange{
|
|
col: 20,
|
|
Range: result.Range{
|
|
From: 5,
|
|
To: 20,
|
|
},
|
|
linters: testcase.linters,
|
|
}
|
|
assert.Equal(t, testcase.expected, ir.doesMatch(&testcase.issue), testcase.doc)
|
|
}
|
|
}
|