
1. Log all warnings, don't hide none of them 2. Write fatal messages (stop analysis) with error log level 3. Remove ugly timestamp counter from logrus output 4. Print nested module prefix in log 5. Make logger abstraction: no global logging anymore 6. Refactor config reading to config.FileReader struct to avoid passing logger into every function 7. Replace exit codes hardcoding with constants in exitcodes package 8. Fail test if any warning was logged 9. Fix calculation of relative path if we analyze parent dir ../ 10. Move Runner initialization from Executor to NewRunner func 11. Log every AST parsing error 12. Properly print used config file path in verbose mode 13. Print package files if only 1 package is analyzedin verbose mode, print not compiling packages in verbose mode 14. Forbid usage of github.com/sirupsen/logrus by DepGuard linter 15. Add default ignore pattern to folint: "comment on exported const"
132 lines
2.3 KiB
Go
132 lines
2.3 KiB
Go
package astcache
|
|
|
|
import (
|
|
"fmt"
|
|
"go/ast"
|
|
"go/parser"
|
|
"go/token"
|
|
"os"
|
|
"path/filepath"
|
|
|
|
"github.com/golangci/golangci-lint/pkg/logutils"
|
|
"golang.org/x/tools/go/loader"
|
|
)
|
|
|
|
type File struct {
|
|
F *ast.File
|
|
Fset *token.FileSet
|
|
Name string
|
|
Err error
|
|
}
|
|
|
|
type Cache struct {
|
|
m map[string]*File
|
|
s []*File
|
|
log logutils.Log
|
|
}
|
|
|
|
func NewCache(log logutils.Log) *Cache {
|
|
return &Cache{
|
|
m: map[string]*File{},
|
|
log: log,
|
|
}
|
|
}
|
|
|
|
func (c Cache) Get(filename string) *File {
|
|
return c.m[filepath.Clean(filename)]
|
|
}
|
|
|
|
func (c Cache) GetOrParse(filename string) *File {
|
|
f := c.m[filename]
|
|
if f != nil {
|
|
return f
|
|
}
|
|
|
|
c.log.Infof("Parse AST for file %s on demand", filename)
|
|
c.parseFile(filename, nil)
|
|
return c.m[filename]
|
|
}
|
|
|
|
func (c Cache) GetAllValidFiles() []*File {
|
|
return c.s
|
|
}
|
|
|
|
func (c *Cache) prepareValidFiles() {
|
|
files := make([]*File, 0, len(c.m))
|
|
for _, f := range c.m {
|
|
if f.Err != nil || f.F == nil {
|
|
continue
|
|
}
|
|
files = append(files, f)
|
|
}
|
|
c.s = files
|
|
}
|
|
|
|
func LoadFromProgram(prog *loader.Program) (*Cache, error) {
|
|
c := &Cache{
|
|
m: map[string]*File{},
|
|
}
|
|
|
|
root, err := os.Getwd()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("can't get working dir: %s", err)
|
|
}
|
|
|
|
for _, pkg := range prog.InitialPackages() {
|
|
for _, f := range pkg.Files {
|
|
pos := prog.Fset.Position(f.Pos())
|
|
if pos.Filename == "" {
|
|
continue
|
|
}
|
|
|
|
relPath, err := filepath.Rel(root, pos.Filename)
|
|
if err != nil {
|
|
c.log.Warnf("Can't get relative path for %s and %s: %s",
|
|
root, pos.Filename, err)
|
|
continue
|
|
}
|
|
|
|
c.m[relPath] = &File{
|
|
F: f,
|
|
Fset: prog.Fset,
|
|
Name: relPath,
|
|
}
|
|
}
|
|
}
|
|
|
|
c.prepareValidFiles()
|
|
return c, nil
|
|
}
|
|
|
|
func (c *Cache) parseFile(filePath string, fset *token.FileSet) {
|
|
if fset == nil {
|
|
fset = token.NewFileSet()
|
|
}
|
|
|
|
f, err := parser.ParseFile(fset, filePath, nil, parser.ParseComments) // comments needed by e.g. golint
|
|
c.m[filePath] = &File{
|
|
F: f,
|
|
Fset: fset,
|
|
Err: err,
|
|
Name: filePath,
|
|
}
|
|
if err != nil {
|
|
c.log.Warnf("Can't parse AST of %s: %s", filePath, err)
|
|
}
|
|
}
|
|
|
|
func LoadFromFiles(files []string) (*Cache, error) {
|
|
c := &Cache{
|
|
m: map[string]*File{},
|
|
}
|
|
|
|
fset := token.NewFileSet()
|
|
for _, filePath := range files {
|
|
filePath = filepath.Clean(filePath)
|
|
c.parseFile(filePath, fset)
|
|
}
|
|
|
|
c.prepareValidFiles()
|
|
return c, nil
|
|
}
|