9181ca7175
1. Log all warnings, don't hide none of them 2. Write fatal messages (stop analysis) with error log level 3. Remove ugly timestamp counter from logrus output 4. Print nested module prefix in log 5. Make logger abstraction: no global logging anymore 6. Refactor config reading to config.FileReader struct to avoid passing logger into every function 7. Replace exit codes hardcoding with constants in exitcodes package 8. Fail test if any warning was logged 9. Fix calculation of relative path if we analyze parent dir ../ 10. Move Runner initialization from Executor to NewRunner func 11. Log every AST parsing error 12. Properly print used config file path in verbose mode 13. Print package files if only 1 package is analyzedin verbose mode, print not compiling packages in verbose mode 14. Forbid usage of github.com/sirupsen/logrus by DepGuard linter 15. Add default ignore pattern to folint: "comment on exported const"
94 lines
2.7 KiB
Go
94 lines
2.7 KiB
Go
package commands
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"runtime"
|
|
"runtime/pprof"
|
|
|
|
"github.com/golangci/golangci-lint/pkg/config"
|
|
"github.com/golangci/golangci-lint/pkg/logutils"
|
|
"github.com/golangci/golangci-lint/pkg/printers"
|
|
"github.com/spf13/cobra"
|
|
"github.com/spf13/pflag"
|
|
)
|
|
|
|
func (e *Executor) persistentPreRun(cmd *cobra.Command, args []string) {
|
|
if e.cfg.Run.PrintVersion {
|
|
fmt.Fprintf(printers.StdOut, "golangci-lint has version %s built from %s on %s\n", e.version, e.commit, e.date)
|
|
os.Exit(0)
|
|
}
|
|
|
|
runtime.GOMAXPROCS(e.cfg.Run.Concurrency)
|
|
|
|
logutils.SetupVerboseLog(e.log, e.cfg.Run.IsVerbose)
|
|
|
|
if e.cfg.Run.CPUProfilePath != "" {
|
|
f, err := os.Create(e.cfg.Run.CPUProfilePath)
|
|
if err != nil {
|
|
e.log.Fatalf("Can't create file %s: %s", e.cfg.Run.CPUProfilePath, err)
|
|
}
|
|
if err := pprof.StartCPUProfile(f); err != nil {
|
|
e.log.Fatalf("Can't start CPU profiling: %s", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (e *Executor) persistentPostRun(cmd *cobra.Command, args []string) {
|
|
if e.cfg.Run.CPUProfilePath != "" {
|
|
pprof.StopCPUProfile()
|
|
}
|
|
if e.cfg.Run.MemProfilePath != "" {
|
|
f, err := os.Create(e.cfg.Run.MemProfilePath)
|
|
if err != nil {
|
|
e.log.Fatalf("Can't create file %s: %s", e.cfg.Run.MemProfilePath, err)
|
|
}
|
|
runtime.GC() // get up-to-date statistics
|
|
if err := pprof.WriteHeapProfile(f); err != nil {
|
|
e.log.Fatalf("Can't write heap profile: %s", err)
|
|
}
|
|
}
|
|
|
|
os.Exit(e.exitCode)
|
|
}
|
|
|
|
func getDefaultConcurrency() int {
|
|
if os.Getenv("HELP_RUN") == "1" {
|
|
return 8 // to make stable concurrency for README help generating builds
|
|
}
|
|
|
|
return runtime.NumCPU()
|
|
}
|
|
|
|
func (e *Executor) initRoot() {
|
|
rootCmd := &cobra.Command{
|
|
Use: "golangci-lint",
|
|
Short: "golangci-lint is a smart linters runner.",
|
|
Long: `Smart, fast linters runner. Run it in cloud for every GitHub pull request on https://golangci.com`,
|
|
Run: func(cmd *cobra.Command, args []string) {
|
|
if err := cmd.Help(); err != nil {
|
|
e.log.Fatalf("Can't run help: %s", err)
|
|
}
|
|
},
|
|
PersistentPreRun: e.persistentPreRun,
|
|
PersistentPostRun: e.persistentPostRun,
|
|
}
|
|
|
|
initRootFlagSet(rootCmd.PersistentFlags(), e.cfg, e.needVersionOption())
|
|
e.rootCmd = rootCmd
|
|
}
|
|
|
|
func (e *Executor) needVersionOption() bool {
|
|
return e.date != ""
|
|
}
|
|
|
|
func initRootFlagSet(fs *pflag.FlagSet, cfg *config.Config, needVersionOption bool) {
|
|
fs.BoolVarP(&cfg.Run.IsVerbose, "verbose", "v", false, wh("verbose output"))
|
|
fs.StringVar(&cfg.Run.CPUProfilePath, "cpu-profile-path", "", wh("Path to CPU profile output file"))
|
|
fs.StringVar(&cfg.Run.MemProfilePath, "mem-profile-path", "", wh("Path to memory profile output file"))
|
|
fs.IntVarP(&cfg.Run.Concurrency, "concurrency", "j", getDefaultConcurrency(), wh("Concurrency (default NumCPU)"))
|
|
if needVersionOption {
|
|
fs.BoolVar(&cfg.Run.PrintVersion, "version", false, wh("Print version"))
|
|
}
|
|
}
|