7705f82591
Also do following improvements: - show proper sublinter name for megacheck sublinters - refactor and make more simple and robust megacheck merging/optimizing - improve handling of unknown linter names in //nolint directives - minimize diff of our megacheck version from the upstream, https://github.com/golang/go/issues/29612 blocks usage of the upstream version - support the new `stylecheck` linter - improve tests coverage for megacheck and nolint related cases - update and use upstream versions of unparam and interfacer instead of forked ones - don't use golangci/tools repo anymore - fix newly found issues after updating linters Also should be noted that megacheck works much faster and consumes less memory in the newest release, therefore golangci-lint works noticeably faster and consumes less memory for large repos. Relates: #314
25 lines
589 B
Go
25 lines
589 B
Go
package functions
|
|
|
|
import "github.com/golangci/go-tools/ssa"
|
|
|
|
// terminates reports whether fn is supposed to return, that is if it
|
|
// has at least one theoretic path that returns from the function.
|
|
// Explicit panics do not count as terminating.
|
|
func terminates(fn *ssa.Function) bool {
|
|
if fn.Blocks == nil {
|
|
// assuming that a function terminates is the conservative
|
|
// choice
|
|
return true
|
|
}
|
|
|
|
for _, block := range fn.Blocks {
|
|
if len(block.Instrs) == 0 {
|
|
continue
|
|
}
|
|
if _, ok := block.Instrs[len(block.Instrs)-1].(*ssa.Return); ok {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|