0421bac259
Use go/packages instead of x/tools/loader: it allows to work with go modules and speedups loading of packages with the help of build cache. A lot of linters became "fast": they are enabled by --fast now and work in 1-2 seconds. Only unparam, interfacer and megacheck are "slow" linters now. Average project is analyzed 20-40% faster than before if all linters are enabled! If we enable all linters except unparam, interfacer and megacheck analysis is 10-20x faster!
64 lines
1.6 KiB
Go
64 lines
1.6 KiB
Go
package golinters
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
goconstAPI "github.com/golangci/goconst"
|
|
"github.com/golangci/golangci-lint/pkg/lint/linter"
|
|
"github.com/golangci/golangci-lint/pkg/result"
|
|
)
|
|
|
|
type Goconst struct{}
|
|
|
|
func (Goconst) Name() string {
|
|
return "goconst"
|
|
}
|
|
|
|
func (Goconst) Desc() string {
|
|
return "Finds repeated strings that could be replaced by a constant"
|
|
}
|
|
|
|
func (lint Goconst) Run(ctx context.Context, lintCtx *linter.Context) ([]result.Issue, error) {
|
|
var goconstIssues []goconstAPI.Issue
|
|
cfg := goconstAPI.Config{
|
|
MatchWithConstants: true,
|
|
MinStringLength: lintCtx.Settings().Goconst.MinStringLen,
|
|
MinOccurrences: lintCtx.Settings().Goconst.MinOccurrencesCount,
|
|
}
|
|
for _, pkg := range lintCtx.Packages {
|
|
files, fset, err := getASTFilesForGoPkg(lintCtx, pkg)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
issues, err := goconstAPI.Run(files, fset, &cfg)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
goconstIssues = append(goconstIssues, issues...)
|
|
}
|
|
if len(goconstIssues) == 0 {
|
|
return nil, nil
|
|
}
|
|
|
|
res := make([]result.Issue, 0, len(goconstIssues))
|
|
for _, i := range goconstIssues {
|
|
textBegin := fmt.Sprintf("string %s has %d occurrences", formatCode(i.Str, lintCtx.Cfg), i.OccurencesCount)
|
|
var textEnd string
|
|
if i.MatchingConst == "" {
|
|
textEnd = ", make it a constant"
|
|
} else {
|
|
textEnd = fmt.Sprintf(", but such constant %s already exists", formatCode(i.MatchingConst, lintCtx.Cfg))
|
|
}
|
|
res = append(res, result.Issue{
|
|
Pos: i.Pos,
|
|
Text: textBegin + textEnd,
|
|
FromLinter: lint.Name(),
|
|
})
|
|
}
|
|
|
|
return res, nil
|
|
}
|