692dacb773
New checkers were added: - badCall - dupImports - evalOrder - newDeref The following checkers were fixed/improved: - assignOp - caseOrder - commentedOutCode - deprecatedComment - dupArg - rangeValCopy - typeSwitchVar - wrapperFunc Relates: #429
64 lines
1.3 KiB
Go
64 lines
1.3 KiB
Go
package checkers
|
|
|
|
import (
|
|
"fmt"
|
|
"go/ast"
|
|
|
|
"github.com/go-lintpack/lintpack"
|
|
)
|
|
|
|
func init() {
|
|
var info lintpack.CheckerInfo
|
|
info.Name = "dupImport"
|
|
info.Tags = []string{"style", "experimental"}
|
|
info.Summary = "Detects multiple imports of the same package under different aliases"
|
|
info.Before = `
|
|
import (
|
|
"fmt"
|
|
priting "fmt" // Imported the second time
|
|
)`
|
|
info.After = `
|
|
import(
|
|
"fmt"
|
|
)`
|
|
|
|
collection.AddChecker(&info, func(ctx *lintpack.CheckerContext) lintpack.FileWalker {
|
|
return &dupImportChecker{ctx: ctx}
|
|
})
|
|
}
|
|
|
|
type dupImportChecker struct {
|
|
ctx *lintpack.CheckerContext
|
|
}
|
|
|
|
func (c *dupImportChecker) WalkFile(f *ast.File) {
|
|
imports := make(map[string][]*ast.ImportSpec)
|
|
for _, importDcl := range f.Imports {
|
|
pkg := importDcl.Path.Value
|
|
imports[pkg] = append(imports[pkg], importDcl)
|
|
}
|
|
|
|
for _, importList := range imports {
|
|
if len(importList) == 1 {
|
|
continue
|
|
}
|
|
c.warn(importList)
|
|
}
|
|
}
|
|
|
|
func (c *dupImportChecker) warn(importList []*ast.ImportSpec) {
|
|
msg := fmt.Sprintf("package is imported %d times under different aliases on lines", len(importList))
|
|
for idx, importDcl := range importList {
|
|
switch {
|
|
case idx == len(importList)-1:
|
|
msg += " and"
|
|
case idx > 0:
|
|
msg += ","
|
|
}
|
|
msg += fmt.Sprintf(" %d", c.ctx.FileSet.Position(importDcl.Pos()).Line)
|
|
}
|
|
for _, importDcl := range importList {
|
|
c.ctx.Warn(importDcl, msg)
|
|
}
|
|
}
|