7f48cc88b8
If the target files contains `//line` directive and it indicates a non-go file, the linter is going to handle it as a go file, which results in failure. The cause of this issue is that the linters (`Analyzer`s) are using `pass.Fset.Position()`. This func returns the adjusted position using `//line` directive. The example project reported in #998 has `//line` directive that indicates other non-go file. According to the description of "Compiler Directives” (https://golang.org/cmd/compile/#hdr-Compiler_Directives), line directives is mainly used for reporting original positions to the generators or something. On linters of golangci-lint, `pass.Fset.Position()` is used just to aggregate file names; we don't have to adjust positions. This changes `Analyzer`s that use `pass.Fset.Position()` to aggregate file names to use `pass.Fset.PositionFor()` with `adjusted == false`. Relates: #998
74 lines
1.8 KiB
Go
74 lines
1.8 KiB
Go
package golinters
|
|
|
|
import (
|
|
"sync"
|
|
|
|
goimportsAPI "github.com/golangci/gofmt/goimports"
|
|
"github.com/pkg/errors"
|
|
"golang.org/x/tools/go/analysis"
|
|
"golang.org/x/tools/imports"
|
|
|
|
"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
|
|
"github.com/golangci/golangci-lint/pkg/lint/linter"
|
|
)
|
|
|
|
const goimportsName = "goimports"
|
|
|
|
func NewGoimports() *goanalysis.Linter {
|
|
var mu sync.Mutex
|
|
var resIssues []goanalysis.Issue
|
|
|
|
analyzer := &analysis.Analyzer{
|
|
Name: goimportsName,
|
|
Doc: goanalysis.TheOnlyanalyzerDoc,
|
|
}
|
|
return goanalysis.NewLinter(
|
|
goimportsName,
|
|
"Goimports does everything that gofmt does. Additionally it checks unused imports",
|
|
[]*analysis.Analyzer{analyzer},
|
|
nil,
|
|
).WithContextSetter(func(lintCtx *linter.Context) {
|
|
imports.LocalPrefix = lintCtx.Settings().Goimports.LocalPrefixes
|
|
analyzer.Run = func(pass *analysis.Pass) (interface{}, error) {
|
|
var fileNames []string
|
|
for _, f := range pass.Files {
|
|
pos := pass.Fset.PositionFor(f.Pos(), false)
|
|
fileNames = append(fileNames, pos.Filename)
|
|
}
|
|
|
|
var issues []goanalysis.Issue
|
|
|
|
for _, f := range fileNames {
|
|
diff, err := goimportsAPI.Run(f)
|
|
if err != nil { // TODO: skip
|
|
return nil, err
|
|
}
|
|
if diff == nil {
|
|
continue
|
|
}
|
|
|
|
is, err := extractIssuesFromPatch(string(diff), lintCtx.Log, lintCtx, true)
|
|
if err != nil {
|
|
return nil, errors.Wrapf(err, "can't extract issues from gofmt diff output %q", string(diff))
|
|
}
|
|
|
|
for i := range is {
|
|
issues = append(issues, goanalysis.NewIssue(&is[i], pass))
|
|
}
|
|
}
|
|
|
|
if len(issues) == 0 {
|
|
return nil, nil
|
|
}
|
|
|
|
mu.Lock()
|
|
resIssues = append(resIssues, issues...)
|
|
mu.Unlock()
|
|
|
|
return nil, nil
|
|
}
|
|
}).WithIssuesReporter(func(*linter.Context) []goanalysis.Issue {
|
|
return resIssues
|
|
}).WithLoadMode(goanalysis.LoadModeSyntax)
|
|
}
|