52c9b88c25
The primary improvement is in early clearing of
analyzed package's TypeInfo, facts, etc for
whole program analyzers (`unused`). Clear it when it
becomes unused and GC collects them early. Initially this
clearing was performed for all analyzers except `unused`.
Update staticcheck from v0.0.1-2019.2.3 to v0.0.1-2020.1.4
Also in this commit:
* speed up loading packages from export data (2.5s -> 2.1s for std)
by not using mutex for export data since it was allowed in
x/tools#07722704da13
* make an order of execution of linters stable
* update renameio and robustio
* use robustio in caching
Relates: #987, #994, #995, #1011
66 lines
1.8 KiB
Go
66 lines
1.8 KiB
Go
package golinters
|
|
|
|
import (
|
|
"go/types"
|
|
|
|
"golang.org/x/tools/go/analysis"
|
|
"golang.org/x/tools/go/packages"
|
|
"honnef.co/go/tools/unused"
|
|
|
|
"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
|
|
"github.com/golangci/golangci-lint/pkg/lint/linter"
|
|
"github.com/golangci/golangci-lint/pkg/result"
|
|
)
|
|
|
|
func NewUnused() *goanalysis.Linter {
|
|
u := unused.NewChecker(false)
|
|
analyzers := []*analysis.Analyzer{u.Analyzer()}
|
|
setAnalyzersGoVersion(analyzers)
|
|
|
|
const name = "unused"
|
|
lnt := goanalysis.NewLinter(
|
|
name,
|
|
"Checks Go code for unused constants, variables, functions and types",
|
|
analyzers,
|
|
nil,
|
|
).WithIssuesReporter(func(lintCtx *linter.Context) []goanalysis.Issue {
|
|
typesToPkg := map[*types.Package]*packages.Package{}
|
|
for _, pkg := range lintCtx.OriginalPackages {
|
|
typesToPkg[pkg.Types] = pkg
|
|
}
|
|
|
|
var issues []goanalysis.Issue
|
|
for _, ur := range u.Result() {
|
|
p := u.ProblemObject(lintCtx.Packages[0].Fset, ur)
|
|
pkg := typesToPkg[ur.Pkg()]
|
|
i := &result.Issue{
|
|
FromLinter: name,
|
|
Text: p.Message,
|
|
Pos: p.Pos,
|
|
Pkg: pkg,
|
|
LineRange: &result.Range{
|
|
From: p.Pos.Line,
|
|
To: p.End.Line,
|
|
},
|
|
}
|
|
// See https://github.com/golangci/golangci-lint/issues/1048
|
|
// If range is invalid, this will break `--fix` mode.
|
|
if i.LineRange.To >= i.LineRange.From {
|
|
i.Replacement = &result.Replacement{
|
|
// Suggest deleting unused stuff.
|
|
NeedOnlyDelete: true,
|
|
}
|
|
}
|
|
issues = append(issues, goanalysis.NewIssue(i, nil))
|
|
}
|
|
return issues
|
|
}).WithContextSetter(func(lintCtx *linter.Context) {
|
|
if lintCtx.Settings().Unused.CheckExported {
|
|
lintCtx.Log.Infof("Using whole program analysis for unused, it can be memory-heavy")
|
|
u.WholeProgram = true
|
|
}
|
|
}).WithLoadMode(goanalysis.LoadModeWholeProgram)
|
|
lnt.UseOriginalPackages()
|
|
return lnt
|
|
}
|