2b587b63d6
Use build.Import instead of manual parser.ParseFile and paths traversal. It allows:
1. support build tags for all linters.
2. analyze files only for current GOOS/GOARCH: less false-positives.
3. analyze xtest packages (*_test) by golint: upstream golint and
gometalinter can't do it! And don't break analysis on the first xtest
package like it was before.
4. proper handling of xtest packages for linters like goconst where
package boundary is important: less false-positives is expected.
Also:
1. reuse AST parsing for golint and goconst: minor speedup.
2. allow to specify path (not only name) regexp for --skip-files and
--skip-dirs
3. add more default exclude filters for golint about commits:
`(comment on exported (method|function)|should have( a package)?
comment|comment should be of the form)`
4. print skipped dir in verbose (-v) mode
5. refactor per-linter tests: declare arguments in comments, run only
one linter and in combination with slow linter
23 lines
557 B
Go
23 lines
557 B
Go
// args: -Egolint
|
|
package testdata
|
|
|
|
var Go_lint string // ERROR "don't use underscores in Go names; var Go_lint should be GoLint"
|
|
|
|
func ExportedFuncWithNoComment() {
|
|
}
|
|
|
|
var ExportedVarWithNoComment string
|
|
|
|
type ExportedStructWithNoComment struct{}
|
|
|
|
type ExportedInterfaceWithNoComment interface{}
|
|
|
|
// Bad comment
|
|
func ExportedFuncWithBadComment() {}
|
|
|
|
type GolintTest struct{}
|
|
|
|
func (receiver1 GolintTest) A() {}
|
|
|
|
func (receiver2 GolintTest) B() {} // ERROR "receiver name receiver2 should be consistent with previous receiver name receiver1 for GolintTest"
|