full diff: https://github.com/dominikh/go-tools/compare/2019.2.3...2020.1.3 Also updates tests to accomodate updated rules: --- FAIL: TestSourcesFromTestdataWithIssuesDir/staticcheck.go (0.43s) linters_test.go:137: [run --disable-all --print-issued-lines=false --print-linter-name=false --out-format=line-number --max-same-issues=10 -Estaticcheck --no-config testdata/staticcheck.go] linters_test.go:33: Error Trace: linters_test.go:33 linters_test.go:138 linters_test.go:53 Error: Received unexpected error: staticcheck.go:11: no match for `self-assignment of x to x` vs ["SA4006: this value of `x` is never used"] in: staticcheck.go:11:2: SA4006: this value of `x` is never used unmatched errors staticcheck.go:11:2: SA4006: this value of `x` is never used Test: TestSourcesFromTestdataWithIssuesDir/staticcheck.go Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
		
			
				
	
	
		
			71 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			71 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
package irutil
 | 
						|
 | 
						|
import (
 | 
						|
	"honnef.co/go/tools/ir"
 | 
						|
)
 | 
						|
 | 
						|
func Reachable(from, to *ir.BasicBlock) bool {
 | 
						|
	if from == to {
 | 
						|
		return true
 | 
						|
	}
 | 
						|
	if from.Dominates(to) {
 | 
						|
		return true
 | 
						|
	}
 | 
						|
 | 
						|
	found := false
 | 
						|
	Walk(from, func(b *ir.BasicBlock) bool {
 | 
						|
		if b == to {
 | 
						|
			found = true
 | 
						|
			return false
 | 
						|
		}
 | 
						|
		return true
 | 
						|
	})
 | 
						|
	return found
 | 
						|
}
 | 
						|
 | 
						|
func Walk(b *ir.BasicBlock, fn func(*ir.BasicBlock) bool) {
 | 
						|
	seen := map[*ir.BasicBlock]bool{}
 | 
						|
	wl := []*ir.BasicBlock{b}
 | 
						|
	for len(wl) > 0 {
 | 
						|
		b := wl[len(wl)-1]
 | 
						|
		wl = wl[:len(wl)-1]
 | 
						|
		if seen[b] {
 | 
						|
			continue
 | 
						|
		}
 | 
						|
		seen[b] = true
 | 
						|
		if !fn(b) {
 | 
						|
			continue
 | 
						|
		}
 | 
						|
		wl = append(wl, b.Succs...)
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func Vararg(x *ir.Slice) ([]ir.Value, bool) {
 | 
						|
	var out []ir.Value
 | 
						|
	slice, ok := x.X.(*ir.Alloc)
 | 
						|
	if !ok {
 | 
						|
		return nil, false
 | 
						|
	}
 | 
						|
	for _, ref := range *slice.Referrers() {
 | 
						|
		if ref == x {
 | 
						|
			continue
 | 
						|
		}
 | 
						|
		if ref.Block() != x.Block() {
 | 
						|
			return nil, false
 | 
						|
		}
 | 
						|
		idx, ok := ref.(*ir.IndexAddr)
 | 
						|
		if !ok {
 | 
						|
			return nil, false
 | 
						|
		}
 | 
						|
		if len(*idx.Referrers()) != 1 {
 | 
						|
			return nil, false
 | 
						|
		}
 | 
						|
		store, ok := (*idx.Referrers())[0].(*ir.Store)
 | 
						|
		if !ok {
 | 
						|
			return nil, false
 | 
						|
		}
 | 
						|
		out = append(out, store.Val)
 | 
						|
	}
 | 
						|
	return out, true
 | 
						|
}
 |