bf27481efd
full diff: https://github.com/dominikh/go-tools/compare/2019.2.3...2020.1.3 Also updates tests to accomodate updated rules: --- FAIL: TestSourcesFromTestdataWithIssuesDir/staticcheck.go (0.43s) linters_test.go:137: [run --disable-all --print-issued-lines=false --print-linter-name=false --out-format=line-number --max-same-issues=10 -Estaticcheck --no-config testdata/staticcheck.go] linters_test.go:33: Error Trace: linters_test.go:33 linters_test.go:138 linters_test.go:53 Error: Received unexpected error: staticcheck.go:11: no match for `self-assignment of x to x` vs ["SA4006: this value of `x` is never used"] in: staticcheck.go:11:2: SA4006: this value of `x` is never used unmatched errors staticcheck.go:11:2: SA4006: this value of `x` is never used Test: TestSourcesFromTestdataWithIssuesDir/staticcheck.go Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
71 lines
1.5 KiB
Go
71 lines
1.5 KiB
Go
package functions
|
||
|
||
import (
|
||
"go/types"
|
||
|
||
"honnef.co/go/tools/ir"
|
||
)
|
||
|
||
// Terminates reports whether fn is supposed to return, that is if it
|
||
// has at least one theoretic path that returns from the function.
|
||
// Explicit panics do not count as terminating.
|
||
func Terminates(fn *ir.Function) bool {
|
||
if fn.Blocks == nil {
|
||
// assuming that a function terminates is the conservative
|
||
// choice
|
||
return true
|
||
}
|
||
|
||
for _, block := range fn.Blocks {
|
||
if _, ok := block.Control().(*ir.Return); ok {
|
||
if len(block.Preds) == 0 {
|
||
return true
|
||
}
|
||
for _, pred := range block.Preds {
|
||
switch ctrl := pred.Control().(type) {
|
||
case *ir.Panic:
|
||
// explicit panics do not count as terminating
|
||
case *ir.If:
|
||
// Check if we got here by receiving from a closed
|
||
// time.Tick channel – this cannot happen at
|
||
// runtime and thus doesn't constitute termination
|
||
iff := ctrl
|
||
if !ok {
|
||
return true
|
||
}
|
||
ex, ok := iff.Cond.(*ir.Extract)
|
||
if !ok {
|
||
return true
|
||
}
|
||
if ex.Index != 1 {
|
||
return true
|
||
}
|
||
recv, ok := ex.Tuple.(*ir.Recv)
|
||
if !ok {
|
||
return true
|
||
}
|
||
call, ok := recv.Chan.(*ir.Call)
|
||
if !ok {
|
||
return true
|
||
}
|
||
fn, ok := call.Common().Value.(*ir.Function)
|
||
if !ok {
|
||
return true
|
||
}
|
||
fn2, ok := fn.Object().(*types.Func)
|
||
if !ok {
|
||
return true
|
||
}
|
||
if fn2.FullName() != "time.Tick" {
|
||
return true
|
||
}
|
||
default:
|
||
// we've reached the exit block
|
||
return true
|
||
}
|
||
}
|
||
}
|
||
}
|
||
return false
|
||
}
|