bf27481efd
full diff: https://github.com/dominikh/go-tools/compare/2019.2.3...2020.1.3 Also updates tests to accomodate updated rules: --- FAIL: TestSourcesFromTestdataWithIssuesDir/staticcheck.go (0.43s) linters_test.go:137: [run --disable-all --print-issued-lines=false --print-linter-name=false --out-format=line-number --max-same-issues=10 -Estaticcheck --no-config testdata/staticcheck.go] linters_test.go:33: Error Trace: linters_test.go:33 linters_test.go:138 linters_test.go:53 Error: Received unexpected error: staticcheck.go:11: no match for `self-assignment of x to x` vs ["SA4006: this value of `x` is never used"] in: staticcheck.go:11:2: SA4006: this value of `x` is never used unmatched errors staticcheck.go:11:2: SA4006: this value of `x` is never used Test: TestSourcesFromTestdataWithIssuesDir/staticcheck.go Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
33 lines
845 B
Go
33 lines
845 B
Go
package functions
|
|
|
|
import (
|
|
"honnef.co/go/tools/ir"
|
|
)
|
|
|
|
// IsStub reports whether a function is a stub. A function is
|
|
// considered a stub if it has no instructions or if all it does is
|
|
// return a constant value.
|
|
func IsStub(fn *ir.Function) bool {
|
|
for _, b := range fn.Blocks {
|
|
for _, instr := range b.Instrs {
|
|
switch instr.(type) {
|
|
case *ir.Const:
|
|
// const naturally has no side-effects
|
|
case *ir.Panic:
|
|
// panic is a stub if it only uses constants
|
|
case *ir.Return:
|
|
// return is a stub if it only uses constants
|
|
case *ir.DebugRef:
|
|
case *ir.Jump:
|
|
// if there are no disallowed instructions, then we're
|
|
// only jumping to the exit block (or possibly
|
|
// somewhere else that's stubby?)
|
|
default:
|
|
// all other instructions are assumed to do actual work
|
|
return false
|
|
}
|
|
}
|
|
}
|
|
return true
|
|
}
|