56 lines
1.1 KiB
Go
56 lines
1.1 KiB
Go
package checks
|
|
|
|
import (
|
|
"go/ast"
|
|
"go/token"
|
|
|
|
"golang.org/x/tools/go/analysis"
|
|
|
|
config "github.com/tommy-muehle/go-mnd/config"
|
|
)
|
|
|
|
const ConditionCheck = "condition"
|
|
|
|
type ConditionAnalyzer struct {
|
|
pass *analysis.Pass
|
|
config *config.Config
|
|
}
|
|
|
|
func NewConditionAnalyzer(pass *analysis.Pass, config *config.Config) *ConditionAnalyzer {
|
|
return &ConditionAnalyzer{
|
|
pass: pass,
|
|
config: config,
|
|
}
|
|
}
|
|
|
|
func (a *ConditionAnalyzer) NodeFilter() []ast.Node {
|
|
return []ast.Node{
|
|
(*ast.IfStmt)(nil),
|
|
}
|
|
}
|
|
|
|
func (a *ConditionAnalyzer) Check(n ast.Node) {
|
|
expr, ok := n.(*ast.IfStmt).Cond.(*ast.BinaryExpr)
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
switch x := expr.X.(type) {
|
|
case *ast.BasicLit:
|
|
if a.isMagicNumber(x) {
|
|
a.pass.Reportf(x.Pos(), reportMsg, x.Value, ConditionCheck)
|
|
}
|
|
}
|
|
|
|
switch y := expr.Y.(type) {
|
|
case *ast.BasicLit:
|
|
if a.isMagicNumber(y) {
|
|
a.pass.Reportf(y.Pos(), reportMsg, y.Value, ConditionCheck)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (a *ConditionAnalyzer) isMagicNumber(l *ast.BasicLit) bool {
|
|
return (l.Kind == token.FLOAT || l.Kind == token.INT) && !a.config.IsIgnoredNumber(l.Value)
|
|
}
|