package processors import ( "go/token" "path/filepath" "testing" "github.com/golangci/golangci-lint/pkg/result" "github.com/stretchr/testify/assert" ) func newNolintFileIssue(line int, fromLinter string) result.Issue { return result.Issue{ Pos: token.Position{ Filename: filepath.Join("testdata", "nolint.go"), Line: line, }, FromLinter: fromLinter, } } func TestNolint(t *testing.T) { p := NewNolint(token.NewFileSet()) // test inline comments processAssertEmpty(t, p, newNolintFileIssue(3, "gofmt")) processAssertEmpty(t, p, newNolintFileIssue(3, "gofmt")) // check cached is ok processAssertSame(t, p, newNolintFileIssue(3, "gofmtA")) // check different name processAssertEmpty(t, p, newNolintFileIssue(4, "gofmt")) processAssertSame(t, p, newNolintFileIssue(4, "gofmtA")) // check different name processAssertEmpty(t, p, newNolintFileIssue(5, "gofmt")) processAssertEmpty(t, p, newNolintFileIssue(5, "govet")) processAssertSame(t, p, newNolintFileIssue(5, "gofmtA")) // check different name processAssertEmpty(t, p, newNolintFileIssue(6, "any")) processAssertEmpty(t, p, newNolintFileIssue(7, "any")) processAssertSame(t, p, newNolintFileIssue(1, "golint")) // no directive // test preceding comments processAssertEmpty(t, p, newNolintFileIssue(10, "any")) // preceding comment for var processAssertEmpty(t, p, newNolintFileIssue(9, "any")) // preceding comment for var itself processAssertSame(t, p, newNolintFileIssue(14, "any")) // preceding comment with extra \n processAssertEmpty(t, p, newNolintFileIssue(12, "any")) // preceding comment with extra \n itself processAssertSame(t, p, newNolintFileIssue(17, "any")) // preceding comment on different column processAssertEmpty(t, p, newNolintFileIssue(16, "any")) // preceding comment on different column itself // preceding comment for func name and comment itself for i := 19; i <= 23; i++ { processAssertEmpty(t, p, newNolintFileIssue(i, "any")) } processAssertSame(t, p, newNolintFileIssue(24, "any")) // right after func // preceding multiline comment: last line for i := 25; i <= 30; i++ { processAssertEmpty(t, p, newNolintFileIssue(i, "any")) } processAssertSame(t, p, newNolintFileIssue(31, "any")) // between funcs // preceding multiline comment: first line for i := 32; i <= 37; i++ { processAssertEmpty(t, p, newNolintFileIssue(i, "any")) } processAssertSame(t, p, newNolintFileIssue(38, "any")) // between funcs // preceding multiline comment: medium line for i := 39; i <= 45; i++ { processAssertEmpty(t, p, newNolintFileIssue(i, "any")) } } func TestNoIssuesInAutogeneratedFiles(t *testing.T) { files := []string{ "nolint_autogenerated.go", "nolint_autogenerated_alt_hdr.go", "nolint_autogenerated_alt_hdr2.go", } for _, file := range files { t.Run(file, func(t *testing.T) { i := result.Issue{ Pos: token.Position{ Filename: filepath.Join("testdata", file), Line: 4, }, } p := NewNolint(token.NewFileSet()) processAssertEmpty(t, p, i) }) } } func TestIgnoredRangeMatches(t *testing.T) { var testcases = []struct { doc string issue result.Issue linters []string expected bool }{ { doc: "unmatched line", issue: result.Issue{ Pos: token.Position{ Line: 100, }, }, }, { doc: "matched line, all linters", issue: result.Issue{ Pos: token.Position{ Line: 5, }, }, expected: true, }, { doc: "matched line, unmatched linter", issue: result.Issue{ Pos: token.Position{ Line: 5, }, }, linters: []string{"vet"}, }, { doc: "matched line and linters", issue: result.Issue{ Pos: token.Position{ Line: 20, }, FromLinter: "vet", }, linters: []string{"vet"}, expected: true, }, } for _, testcase := range testcases { ir := ignoredRange{ col: 20, Range: result.Range{ From: 5, To: 20, }, linters: testcase.linters, } assert.Equal(t, testcase.expected, ir.doesMatch(&testcase.issue), testcase.doc) } }