Remove executing build and test, there is a special workflow for this and CodeQL does not require running any go code or building the app
Remove `git checkout HEAD^2`, not needed anymore: Warning: 1 issue was detected with this workflow: git checkout HEAD^2 is no longer necessary. Please remove this step as Code Scanning recommends analyzing the merge commit for best results.
Add permission to write the security events
* Remove dead code related to golangci.com
* remove old build tags
* stale bot: remove bug label from `exemptLabels`
* order `gitignore` entries alphabetically
* doc: order `linters-settings` alphabetically
* remove obsolete exclude rule
* release: add docs prefix to skip the commit in the changelog
Extra / Vulnerability scanner (push) Failing after 15m32s
CI / go-mod (push) Failing after 15m30s
CI / golangci-lint (push) Failing after 15m28s
Release a tag / release (push) Failing after 15m26s
CI / tests-on-windows (push) Has been cancelled
CI / tests-on-macos (push) Has been cancelled
CI / tests-on-unix (1.13) (push) Has been cancelled
CI / tests-on-unix (1.14) (push) Has been cancelled
CI / tests-on-unix (1.15) (push) Has been cancelled
CI / check_generated (push) Has been cancelled
Release a tag / docker-release (map[Dockerfile:build/Dockerfile.alpine]) (push) Has been cancelled
Release a tag / docker-release (map[Dockerfile:build/Dockerfile]) (push) Has been cancelled
This commit is to avoid tag overriding due to parallel build for
multiple base images (e.g. debian and alpine).
Closes#1483#1486
Signed-off-by: Tam Mach <sayboras@yahoo.com>
Extra / Vulnerability scanner (push) Failing after 41s
CI / go-mod (push) Failing after 17m9s
CI / golangci-lint (push) Failing after 15m36s
Release a tag / release (push) Failing after 15m34s
CI / tests-on-windows (push) Has been cancelled
CI / tests-on-macos (push) Has been cancelled
CI / tests-on-unix (1.13) (push) Has been cancelled
CI / tests-on-unix (1.14) (push) Has been cancelled
CI / tests-on-unix (1.15) (push) Has been cancelled
CI / check_generated (push) Has been cancelled
Release a tag / docker-release (map[Dockerfile:build/Dockerfile.alpine]) (push) Has been cancelled
Release a tag / docker-release (map[Dockerfile:build/Dockerfile]) (push) Has been cancelled
* build(docker): Fix version details in docker image
As part of #1383, multi-arch docker build was supported. However,
ldflags for version details was missing.
This commit is to add -ldflags as part of Docker build. I take this chance
to refactor github action as well.
Fixes#1468
Signed-off-by: Tam Mach <sayboras@yahoo.com>
This commit is to add codeQL scanning, which is newly introduced feature
from github.
The scan will be run per PR, and periodically as well.
Signed-off-by: Tam Mach <sayboras@yahoo.com>
This commit is to update go-mod github action step to check for only
go.mod file. Ideally, both go.mod and go.sum should be checked, however,
the current behavior of `go mod tidy` command will not clean up old
entries in go.sum.
Additionally, dependentbot is currently failing as there is dirty change
in go.sum file.
Currently nancy is always failed, and we seem to ignore it completely.
This reduces the value of having security scanning significantly.
Ideally, the underlying issue should be fixed, however it will require
long time for external collaboration.
This commit is to ignore two known dependency failures.
Signed-off-by: Tam Mach <sayboras@yahoo.com>
This commit is to add job to check if go.mod and go.sum are up to
date.
Also add go.sum into .gitattributes so that it will be considered
as generated file in PR review.
Signed-off-by: Tam Mach <sayboras@yahoo.com>
Golang 1.15 comes to few improvements, one of them is to have smaller
binary.
This PR is to make golang 1.15 as default version in CI, I also update
Docker based image to golang:1.15* as well.
Two issues faced with golang 1.15:
- Conflict between -v in `golangci-lint` and `go test`. Update to --verbose
to avoid the same. [1]
- `nolintlint_unused.go` testdata is not matching regex. Correct by adding one
space after //
[1]: https://github.com/golang/go/issues/40763
Signed-off-by: Tam Mach <sayboras@yahoo.com>
Run CI on mac os only with go1.13 and on windows only on go1.14.
Speed up tests. Introduce --allow-parallel-runners.
Block on parallel run lock 5s instead of 60s.
Don't invalidate analysis cache for minor config changes.
