From f95b1ed39fb58390dbde896948f3d93435488c76 Mon Sep 17 00:00:00 2001
From: Ludovic Fernandez <ldez@users.noreply.github.com>
Date: Tue, 11 May 2021 00:50:50 +0200
Subject: [PATCH] golint: deprecation (#1965)

---
 .golangci.yml                    | 3 ---
 pkg/lint/lintersdb/manager.go    | 3 ++-
 test/run_test.go                 | 2 +-
 test/testdata/default_exclude.go | 2 +-
 test/testdata/golint.go          | 2 +-
 5 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/.golangci.yml b/.golangci.yml
index 500b82b0..a3e537e4 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -34,8 +34,6 @@ linters-settings:
     min-complexity: 15
   goimports:
     local-prefixes: github.com/golangci/golangci-lint
-  golint:
-    min-confidence: 0
   gomnd:
     settings:
       mnd:
@@ -82,7 +80,6 @@ linters:
     - gocyclo
     - gofmt
     - goimports
-    - golint
     - gomnd
     - goprintffuncname
     - gosec
diff --git a/pkg/lint/lintersdb/manager.go b/pkg/lint/lintersdb/manager.go
index 8b057b34..fc760dc3 100644
--- a/pkg/lint/lintersdb/manager.go
+++ b/pkg/lint/lintersdb/manager.go
@@ -169,7 +169,8 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithSince("v1.0.0").
 			WithLoadForGoAnalysis().
 			WithPresets(linter.PresetStyle).
-			WithURL("https://github.com/golang/lint"),
+			WithURL("https://github.com/golang/lint").
+			Deprecated("The repository of the linter has been archived by the owner.", "v1.41.0", "revive"),
 		linter.NewConfig(golinters.NewRowsErrCheck()).
 			WithSince("v1.23.0").
 			WithLoadForGoAnalysis().
diff --git a/test/run_test.go b/test/run_test.go
index e644b2e9..07a31355 100644
--- a/test/run_test.go
+++ b/test/run_test.go
@@ -91,7 +91,7 @@ func TestTimeoutInConfig(t *testing.T) {
 
 func TestTestsAreLintedByDefault(t *testing.T) {
 	testshared.NewLintRunner(t).Run(getTestDataDir("withtests")).
-		ExpectHasIssue("`if` block ends with a `return`")
+		ExpectHasIssue("don't use `init` function")
 }
 
 func TestCgoOk(t *testing.T) {
diff --git a/test/testdata/default_exclude.go b/test/testdata/default_exclude.go
index beed57ac..d5e44228 100644
--- a/test/testdata/default_exclude.go
+++ b/test/testdata/default_exclude.go
@@ -1,4 +1,4 @@
-//args: -Estylecheck,golint
+//args: -Estylecheck,golint --internal-cmd-test
 //config_path: testdata/configs/default_exclude.yml
 
 /*Package testdata ...*/
diff --git a/test/testdata/golint.go b/test/testdata/golint.go
index 2fc70ed7..c4e1148e 100644
--- a/test/testdata/golint.go
+++ b/test/testdata/golint.go
@@ -1,4 +1,4 @@
-//args: -Egolint
+//args: -Egolint --internal-cmd-test
 package testdata
 
 var Go_lint string // ERROR "don't use underscores in Go names; var `Go_lint` should be `GoLint`"