eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

unused: fix false-positive (#2772)

Browse Source
This commit is contained in:
Ludovic Fernandez 2022-04-19 09:26:01 +02:00 committed by GitHub
parent 333187c066
commit f79bc883fb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
pkg/golinters/unused.go
View File

@ -35,8 +35,27 @@ func NewUnused(settings *config.StaticCheckSettings) *goanalysis.Linter {
sr := unused.Serialize(pass, res.(unused.Result), pass.Fset) sr := unused.Serialize(pass, res.(unused.Result), pass.Fset)
used := make(map[string]bool)
for _, obj := range sr.Used {
used[fmt.Sprintf("%s %d %s", obj.Position.Filename, obj.Position.Line, obj.Name)] = true
}
var issues []goanalysis.Issue var issues []goanalysis.Issue
// Inspired by https://github.com/dominikh/go-tools/blob/d694aadcb1f50c2d8ac0a1dd06217ebb9f654764/lintcmd/lint.go#L177-L197
for _, object := range sr.Unused { for _, object := range sr.Unused {
if object.Kind == "type param" {
continue
}
if object.InGenerated {
continue
}
key := fmt.Sprintf("%s %d %s", object.Position.Filename, object.Position.Line, object.Name)
if used[key] {
continue
}
issue := goanalysis.NewIssue(&result.Issue{ issue := goanalysis.NewIssue(&result.Issue{
FromLinter: name, FromLinter: name,
Text: fmt.Sprintf("%s %s is unused", object.Kind, object.Name), Text: fmt.Sprintf("%s %s is unused", object.Kind, object.Name),