eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

dev: bytes.NewBuffer/bytes.NewBufferString to shorten initialization (#3632)

Browse Source
This commit is contained in:
Oleksandr Redko 2023-02-24 17:40:18 +02:00 committed by GitHub
parent ca5738e1fe
commit f4fec8c6d0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/commands/executor.go
View File

@ -157,8 +157,7 @@ func (e *Executor) initHashSalt(version string) error {
return fmt.Errorf("failed to calculate config salt: %w", err) return fmt.Errorf("failed to calculate config salt: %w", err)
} }
var b bytes.Buffer b := bytes.NewBuffer(binSalt)
b.Write(binSalt)
b.Write(configSalt) b.Write(configSalt)
cache.SetSalt(b.Bytes()) cache.SetSalt(b.Bytes())
return nil return nil
@ -198,8 +197,7 @@ func computeConfigSalt(cfg *config.Config) ([]byte, error) {
return nil, fmt.Errorf("failed to json marshal config linter settings: %w", err) return nil, fmt.Errorf("failed to json marshal config linter settings: %w", err)
} }
var configData bytes.Buffer configData := bytes.NewBufferString("linters-settings=")
configData.WriteString("linters-settings=")
configData.Write(lintersSettingsBytes) configData.Write(lintersSettingsBytes)
configData.WriteString("\nbuild-tags=%s" + strings.Join(cfg.Run.BuildTags, ",")) configData.WriteString("\nbuild-tags=%s" + strings.Join(cfg.Run.BuildTags, ","))

8
pkg/golinters/gofumpt.go
View File

@ -88,13 +88,9 @@ func runGofumpt(lintCtx *linter.Context, pass *analysis.Pass, diff differ, optio
} }
if !bytes.Equal(input, output) { if !bytes.Equal(input, output) {
out := bytes.Buffer{} out := bytes.NewBufferString(fmt.Sprintf("--- %[1]s\n+++ %[1]s\n", f))
_, err = out.WriteString(fmt.Sprintf("--- %[1]s\n+++ %[1]s\n", f))
if err != nil {
return nil, fmt.Errorf("error while running gofumpt: %w", err)
}
err = diff.Diff(&out, bytes.NewReader(input), bytes.NewReader(output)) err := diff.Diff(out, bytes.NewReader(input), bytes.NewReader(output))
if err != nil { if err != nil {
return nil, fmt.Errorf("error while running gofumpt: %w", err) return nil, fmt.Errorf("error while running gofumpt: %w", err)
} }

3
scripts/expand_website_templates/main.go
View File

@ -64,8 +64,7 @@ func updateStateFile(replacements map[string]string) error {
return err return err
} }
var contentBuf bytes.Buffer contentBuf := bytes.NewBufferString("This file stores hash of website templates to trigger " +
contentBuf.WriteString("This file stores hash of website templates to trigger " +
"Netlify rebuild when something changes, e.g. new linter is added.\n") "Netlify rebuild when something changes, e.g. new linter is added.\n")
contentBuf.WriteString(hex.EncodeToString(h.Sum(nil))) contentBuf.WriteString(hex.EncodeToString(h.Sum(nil)))