eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

dev: reused exit codes (#2364)

Browse Source
This commit is contained in:
Alexander Melentyev 2021-11-18 21:46:44 +03:00 committed by GitHub
parent 9cdc7af391
commit ef928947b5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/commands/cache.go
View File

@ -8,6 +8,7 @@ import (
"github.com/spf13/cobra" "github.com/spf13/cobra"
"github.com/golangci/golangci-lint/internal/cache" "github.com/golangci/golangci-lint/internal/cache"
"github.com/golangci/golangci-lint/pkg/exitcodes"
"github.com/golangci/golangci-lint/pkg/fsutils" "github.com/golangci/golangci-lint/pkg/fsutils"
"github.com/golangci/golangci-lint/pkg/logutils" "github.com/golangci/golangci-lint/pkg/logutils"
) )
@ -51,7 +52,7 @@ func (e *Executor) executeCleanCache(_ *cobra.Command, args []string) {
e.log.Fatalf("Failed to remove dir %s: %s", cacheDir, err) e.log.Fatalf("Failed to remove dir %s: %s", cacheDir, err)
} }
os.Exit(0) os.Exit(exitcodes.Success)
} }
func (e *Executor) executeCacheStatus(_ *cobra.Command, args []string) { func (e *Executor) executeCacheStatus(_ *cobra.Command, args []string) {
@ -66,7 +67,7 @@ func (e *Executor) executeCacheStatus(_ *cobra.Command, args []string) {
fmt.Fprintf(logutils.StdOut, "Size: %s\n", fsutils.PrettifyBytesCount(cacheSizeBytes)) fmt.Fprintf(logutils.StdOut, "Size: %s\n", fsutils.PrettifyBytesCount(cacheSizeBytes))
} }
os.Exit(0) os.Exit(exitcodes.Success)
} }
func dirSizeBytes(path string) (int64, error) { func dirSizeBytes(path string) (int64, error) {

2
pkg/commands/config.go
View File

@ -64,5 +64,5 @@ func (e *Executor) executePathCmd(_ *cobra.Command, args []string) {
} }
fmt.Println(usedConfigFile) fmt.Println(usedConfigFile)
os.Exit(0) os.Exit(exitcodes.Success)
} }

3
pkg/commands/help.go
View File

@ -9,6 +9,7 @@ import (
"github.com/fatih/color" "github.com/fatih/color"
"github.com/spf13/cobra" "github.com/spf13/cobra"
"github.com/golangci/golangci-lint/pkg/exitcodes"
"github.com/golangci/golangci-lint/pkg/lint/linter" "github.com/golangci/golangci-lint/pkg/lint/linter"
"github.com/golangci/golangci-lint/pkg/logutils" "github.com/golangci/golangci-lint/pkg/logutils"
) )
@ -93,5 +94,5 @@ func (e *Executor) executeLintersHelp(_ *cobra.Command, args []string) {
fmt.Fprintf(logutils.StdOut, "%s: %s\n", color.YellowString(p), strings.Join(linterNames, ", ")) fmt.Fprintf(logutils.StdOut, "%s: %s\n", color.YellowString(p), strings.Join(linterNames, ", "))
} }
os.Exit(0) os.Exit(exitcodes.Success)
} }

3
pkg/commands/linters.go
View File

@ -7,6 +7,7 @@ import (
"github.com/fatih/color" "github.com/fatih/color"
"github.com/spf13/cobra" "github.com/spf13/cobra"
"github.com/golangci/golangci-lint/pkg/exitcodes"
"github.com/golangci/golangci-lint/pkg/lint/linter" "github.com/golangci/golangci-lint/pkg/lint/linter"
) )
@ -48,5 +49,5 @@ func (e *Executor) executeLinters(_ *cobra.Command, args []string) {
color.Red("\nDisabled by your configuration linters:\n") color.Red("\nDisabled by your configuration linters:\n")
printLinterConfigs(disabledLCs) printLinterConfigs(disabledLCs)
os.Exit(0) os.Exit(exitcodes.Success)
} }

3
pkg/commands/root.go
View File

@ -12,13 +12,14 @@ import (
"github.com/spf13/pflag" "github.com/spf13/pflag"
"github.com/golangci/golangci-lint/pkg/config" "github.com/golangci/golangci-lint/pkg/config"
"github.com/golangci/golangci-lint/pkg/exitcodes"
"github.com/golangci/golangci-lint/pkg/logutils" "github.com/golangci/golangci-lint/pkg/logutils"
) )
func (e *Executor) persistentPreRun(_ *cobra.Command, _ []string) { func (e *Executor) persistentPreRun(_ *cobra.Command, _ []string) {
if e.cfg.Run.PrintVersion { if e.cfg.Run.PrintVersion {
fmt.Fprintf(logutils.StdOut, "golangci-lint has version %s built from %s on %s\n", e.version, e.commit, e.date) fmt.Fprintf(logutils.StdOut, "golangci-lint has version %s built from %s on %s\n", e.version, e.commit, e.date)
os.Exit(0) os.Exit(exitcodes.Success)
} }
runtime.GOMAXPROCS(e.cfg.Run.Concurrency) runtime.GOMAXPROCS(e.cfg.Run.Concurrency)

3
pkg/config/reader.go
View File

@ -10,6 +10,7 @@ import (
"github.com/mitchellh/go-homedir" "github.com/mitchellh/go-homedir"
"github.com/spf13/viper" "github.com/spf13/viper"
"github.com/golangci/golangci-lint/pkg/exitcodes"
"github.com/golangci/golangci-lint/pkg/fsutils" "github.com/golangci/golangci-lint/pkg/fsutils"
"github.com/golangci/golangci-lint/pkg/logutils" "github.com/golangci/golangci-lint/pkg/logutils"
"github.com/golangci/golangci-lint/pkg/sliceutil" "github.com/golangci/golangci-lint/pkg/sliceutil"
@ -87,7 +88,7 @@ func (r *FileReader) parseConfig() error {
if r.cfg.InternalTest { // just for testing purposes: to detect config file usage if r.cfg.InternalTest { // just for testing purposes: to detect config file usage
fmt.Fprintln(logutils.StdOut, "test") fmt.Fprintln(logutils.StdOut, "test")
os.Exit(0) os.Exit(exitcodes.Success)
} }
return nil return nil