eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Fixing linter issues

Browse Source
This commit is contained in:
Viktoras Makauskas 2020-04-10 23:59:07 +03:00
parent d7222c7d38
commit ee2c62132c
2 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/printers/github.go
View File

@ -3,6 +3,7 @@ package printers
import ( import (
"context" "context"
"fmt" "fmt"
"github.com/golangci/golangci-lint/pkg/logutils" "github.com/golangci/golangci-lint/pkg/logutils"
"github.com/golangci/golangci-lint/pkg/result" "github.com/golangci/golangci-lint/pkg/result"
) )
@ -17,19 +18,19 @@ func NewGithub() Printer {
} }
// print each line as: ::error file=app.js,line=10,col=15::Something went wrong // print each line as: ::error file=app.js,line=10,col=15::Something went wrong
func formatIssueAsGithub(issue result.Issue) string { func formatIssueAsGithub(issue *result.Issue) string {
result := fmt.Sprintf("::error file=%s,line=%d", issue.FilePath(), issue.Line()) ret := fmt.Sprintf("::error file=%s,line=%d", issue.FilePath(), issue.Line())
if issue.Pos.Column != 0 { if issue.Pos.Column != 0 {
result += fmt.Sprintf(",col=%d", issue.Pos.Column) ret += fmt.Sprintf(",col=%d", issue.Pos.Column)
} }
result += fmt.Sprintf("::%s (%s)", issue.Text, issue.FromLinter) ret += fmt.Sprintf("::%s (%s)", issue.Text, issue.FromLinter)
return result return ret
} }
func (g *github) Print(ctx context.Context, issues []result.Issue) error { func (g *github) Print(ctx context.Context, issues []result.Issue) error {
for _, issue := range issues { for _, issue := range issues {
_, err := fmt.Fprintln(logutils.StdOut, formatIssueAsGithub(issue)) _, err := fmt.Fprintln(logutils.StdOut, formatIssueAsGithub(&issue))
if err != nil { if err != nil {
return err return err
} }

10
pkg/printers/github_test.go
View File

@ -1,10 +1,12 @@
package printers package printers
import ( import (
"github.com/golangci/golangci-lint/pkg/result"
"github.com/stretchr/testify/require"
"go/token" "go/token"
"testing" "testing"
"github.com/stretchr/testify/require"
"github.com/golangci/golangci-lint/pkg/result"
) )
func TestFormatGithubIssue(t *testing.T) { func TestFormatGithubIssue(t *testing.T) {
@ -18,8 +20,8 @@ func TestFormatGithubIssue(t *testing.T) {
Column: 4, Column: 4,
}, },
} }
require.Equal(t, "::error file=path/to/file.go,line=10,col=4::some issue (sample-linter)", formatIssueAsGithub(sampleIssue)) require.Equal(t, "::error file=path/to/file.go,line=10,col=4::some issue (sample-linter)", formatIssueAsGithub(&sampleIssue))
sampleIssue.Pos.Column = 0 sampleIssue.Pos.Column = 0
require.Equal(t, "::error file=path/to/file.go,line=10::some issue (sample-linter)", formatIssueAsGithub(sampleIssue)) require.Equal(t, "::error file=path/to/file.go,line=10::some issue (sample-linter)", formatIssueAsGithub(&sampleIssue))
} }