eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

dev: enable testifylint linter (#4595)

Browse Source
This commit is contained in:
Oleksandr Redko 2024-03-29 16:38:00 +02:00 committed by GitHub
parent f96314f5a3
commit ec9755157e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.golangci.yml
View File

@ -133,6 +133,7 @@ linters:
- revive - revive
- staticcheck - staticcheck
- stylecheck - stylecheck
- testifylint
- unconvert - unconvert
- unparam - unparam
- unused - unused
@ -213,4 +214,3 @@ issues:
run: run:
timeout: 5m timeout: 5m

2
pkg/golinters/misspell_test.go
View File

@ -29,7 +29,7 @@ func Test_appendExtraWords(t *testing.T) {
expected := []string{"iff", "if", "cancelation", "cancellation"} expected := []string{"iff", "if", "cancelation", "cancellation"}
assert.Equal(t, replacer.Replacements, expected) assert.Equal(t, expected, replacer.Replacements)
} }
func Test_appendExtraWords_error(t *testing.T) { func Test_appendExtraWords_error(t *testing.T) {

1
pkg/result/processors/autogenerated_exclude_test.go
View File

@ -252,6 +252,7 @@ func Test_shouldPassIssue_error(t *testing.T) {
pass, err := p.shouldPassIssue(test.issue) pass, err := p.shouldPassIssue(test.issue)
//nolint:testifylint // It's a loop and the main expectation is the error message.
assert.EqualError(t, err, test.expected) assert.EqualError(t, err, test.expected)
assert.False(t, pass) assert.False(t, pass)
}) })

2
pkg/result/processors/skip_files_test.go
View File

@ -49,6 +49,6 @@ func TestSkipFiles(t *testing.T) {
func TestSkipFilesInvalidPattern(t *testing.T) { func TestSkipFilesInvalidPattern(t *testing.T) {
p, err := NewSkipFiles([]string{"\\o"}, "") p, err := NewSkipFiles([]string{"\\o"}, "")
assert.Error(t, err) require.Error(t, err)
assert.Nil(t, p) assert.Nil(t, p)
} }