eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Print error text in <failure> tag content for more readable junit report (#2460)

Browse Source
This commit is contained in:
Donal Byrne 2022-01-05 09:17:33 +01:00 committed by GitHub
parent 63f150ead1
commit eaed228d2f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/printers/junitxml.go
View File

@ -3,6 +3,7 @@ package printers
import ( import (
"context" "context"
"encoding/xml" "encoding/xml"
"fmt"
"io" "io"
"strings" "strings"
@ -31,6 +32,7 @@ type testCaseXML struct {
type failureXML struct { type failureXML struct {
Message string `xml:"message,attr"` Message string `xml:"message,attr"`
Type string `xml:"type,attr"`
Content string `xml:",cdata"` Content string `xml:",cdata"`
} }
@ -57,8 +59,10 @@ func (p JunitXML) Print(ctx context.Context, issues []result.Issue) error {
Name: i.FromLinter, Name: i.FromLinter,
ClassName: i.Pos.String(), ClassName: i.Pos.String(),
Failure: failureXML{ Failure: failureXML{
Message: i.Text, Type: i.Severity,
Content: strings.Join(i.SourceLines, "\n"), Message: i.Pos.String() + ": " + i.Text,
Content: fmt.Sprintf("%s: %s\nCategory: %s\nFile: %s\nLine: %d\nDetails: %s",
i.Severity, i.Text, i.FromLinter, i.Pos.Filename, i.Pos.Line, strings.Join(i.SourceLines, "\n")),
}, },
} }