From ca0052c7d675c4f3a6a93f67580cc7c4daf127e1 Mon Sep 17 00:00:00 2001 From: Ludovic Fernandez Date: Mon, 27 Mar 2023 01:37:47 +0200 Subject: [PATCH] tests: remove go version restrictions (#3730) --- pkg/lint/lintersdb/manager.go | 3 +-- test/testshared/runner.go | 1 - test/testshared/runner_test.go | 10 ---------- 3 files changed, 1 insertion(+), 13 deletions(-) diff --git a/pkg/lint/lintersdb/manager.go b/pkg/lint/lintersdb/manager.go index 128e7909..e1ccdb46 100644 --- a/pkg/lint/lintersdb/manager.go +++ b/pkg/lint/lintersdb/manager.go @@ -770,8 +770,7 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config { WithLoadForGoAnalysis(). WithPresets(linter.PresetUnused). WithURL("https://github.com/opennota/check"). - Deprecated("The owner seems to have abandoned the linter.", "v1.49.0", "unused"). - WithNoopFallback(m.cfg), + Deprecated("The owner seems to have abandoned the linter.", "v1.49.0", "unused"), linter.NewConfig(golinters.NewStylecheck(stylecheckCfg)). WithSince("v1.20.0"). diff --git a/test/testshared/runner.go b/test/testshared/runner.go index 329411a9..2f343f36 100644 --- a/test/testshared/runner.go +++ b/test/testshared/runner.go @@ -164,7 +164,6 @@ func (b *RunnerBuilder) Runner() *Runner { } arguments := []string{ - "--go=1.17", // TODO(ldez): we force to use an old version of Go for the CI and the tests. "--internal-cmd-test", } diff --git a/test/testshared/runner_test.go b/test/testshared/runner_test.go index 74a5cb5f..fd8817cc 100644 --- a/test/testshared/runner_test.go +++ b/test/testshared/runner_test.go @@ -23,7 +23,6 @@ func TestRunnerBuilder_Runner(t *testing.T) { env: []string(nil), command: "run", args: []string{ - "--go=1.17", "--internal-cmd-test", "--allow-parallel-runners", }, @@ -36,7 +35,6 @@ func TestRunnerBuilder_Runner(t *testing.T) { env: []string(nil), command: "example", args: []string{ - "--go=1.17", "--internal-cmd-test", "--allow-parallel-runners", }, @@ -49,7 +47,6 @@ func TestRunnerBuilder_Runner(t *testing.T) { env: []string(nil), command: "run", args: []string{ - "--go=1.17", "--internal-cmd-test", "--allow-parallel-runners", "--no-config", @@ -63,7 +60,6 @@ func TestRunnerBuilder_Runner(t *testing.T) { env: []string(nil), command: "run", args: []string{ - "--go=1.17", "--internal-cmd-test", "--allow-parallel-runners", "-c", @@ -78,7 +74,6 @@ func TestRunnerBuilder_Runner(t *testing.T) { env: []string(nil), command: "run", args: []string{ - "--go=1.17", "--internal-cmd-test", "--allow-parallel-runners", "-c", @@ -96,7 +91,6 @@ func TestRunnerBuilder_Runner(t *testing.T) { env: []string{"FOO=BAR", "FII=BIR"}, command: "run", args: []string{ - "--go=1.17", "--internal-cmd-test", "--allow-parallel-runners", }, @@ -109,7 +103,6 @@ func TestRunnerBuilder_Runner(t *testing.T) { env: []string(nil), command: "run", args: []string{ - "--go=1.17", "--internal-cmd-test", }, }, @@ -121,7 +114,6 @@ func TestRunnerBuilder_Runner(t *testing.T) { env: []string(nil), command: "run", args: []string{ - "--go=1.17", "--internal-cmd-test", "--allow-parallel-runners", "-Efoo", @@ -137,7 +129,6 @@ func TestRunnerBuilder_Runner(t *testing.T) { env: []string(nil), command: "run", args: []string{ - "--go=1.17", "--internal-cmd-test", "--allow-parallel-runners", filepath.FromSlash("testdata/all.go"), @@ -156,7 +147,6 @@ func TestRunnerBuilder_Runner(t *testing.T) { env: []string(nil), command: "run", args: []string{ - "--go=1.17", "--internal-cmd-test", "--allow-parallel-runners", "-c",