eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

fix: don't hide typecheck errors inside diff processor (#4674)

Browse Source
This commit is contained in:
Ludovic Fernandez 2024-04-24 14:54:11 +02:00 committed by GitHub
parent 8bea8e7de8
commit c1f9f54f0d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/result/processors/autogenerated_exclude.go
View File

@ -53,7 +53,7 @@ func (p *AutogeneratedExclude) Process(issues []result.Issue) ([]result.Issue, e
func (*AutogeneratedExclude) Finish() {} func (*AutogeneratedExclude) Finish() {}
func (p *AutogeneratedExclude) shouldPassIssue(issue *result.Issue) (bool, error) { func (p *AutogeneratedExclude) shouldPassIssue(issue *result.Issue) (bool, error) {
if issue.FromLinter == "typecheck" { if issue.FromLinter == typeCheckName {
// don't hide typechecking errors in generated files: users expect to see why the project isn't compiling // don't hide typechecking errors in generated files: users expect to see why the project isn't compiling
return true, nil return true, nil
} }

5
pkg/result/processors/diff.go
View File

@ -65,6 +65,11 @@ func (p Diff) Process(issues []result.Issue) ([]result.Issue, error) {
} }
return transformIssues(issues, func(issue *result.Issue) *result.Issue { return transformIssues(issues, func(issue *result.Issue) *result.Issue {
if issue.FromLinter == typeCheckName {
// Never hide typechecking errors.
return issue
}
hunkPos, isNew := c.IsNewIssue(issue) hunkPos, isNew := c.IsNewIssue(issue)
if !isNew { if !isNew {
return nil return nil

2
pkg/result/processors/invalid_issue.go
View File

@ -23,7 +23,7 @@ func (InvalidIssue) Name() string {
func (p InvalidIssue) Process(issues []result.Issue) ([]result.Issue, error) { func (p InvalidIssue) Process(issues []result.Issue) ([]result.Issue, error) {
tcIssues := filterIssues(issues, func(issue *result.Issue) bool { tcIssues := filterIssues(issues, func(issue *result.Issue) bool {
return issue.FromLinter == "typecheck" return issue.FromLinter == typeCheckName
}) })
if len(tcIssues) > 0 { if len(tcIssues) > 0 {

2
pkg/result/processors/processor.go
View File

@ -4,6 +4,8 @@ import (
"github.com/golangci/golangci-lint/pkg/result" "github.com/golangci/golangci-lint/pkg/result"
) )
const typeCheckName = "typecheck"
type Processor interface { type Processor interface {
Process(issues []result.Issue) ([]result.Issue, error) Process(issues []result.Issue) ([]result.Issue, error)
Name() string Name() string