eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Relates #381, #367: cleanup docs and warn if unparam algo was configured

Browse Source
This commit is contained in:
Denis Isaev 2019-02-11 08:56:49 +03:00
parent 01fb8231f9
commit c1085ef5a2
No known key found for this signature in database
GPG Key ID: A36A0EC8E27A1A01
3 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.golangci.example.yml
View File

@ -128,10 +128,6 @@ linters-settings:
# with golangci-lint call it on a directory with the changed file. # with golangci-lint call it on a directory with the changed file.
check-exported: false check-exported: false
unparam: unparam:
# call graph construction algorithm (cha, rta). In general, use cha for libraries,
# and rta for programs with main packages. Default is cha.
algo: cha
# Inspect exported functions, default is false. Set to true if no external program/library imports your code. # Inspect exported functions, default is false. Set to true if no external program/library imports your code.
# XXX: if you enable this setting, unparam will report a lot of false-positives in text editors: # XXX: if you enable this setting, unparam will report a lot of false-positives in text editors:
# if it's called for subdir of a project it can't find external interfaces. All text editor integrations # if it's called for subdir of a project it can't find external interfaces. All text editor integrations

4
README.md
View File

@ -651,10 +651,6 @@ linters-settings:
# with golangci-lint call it on a directory with the changed file. # with golangci-lint call it on a directory with the changed file.
check-exported: false check-exported: false
unparam: unparam:
# call graph construction algorithm (cha, rta). In general, use cha for libraries,
# and rta for programs with main packages. Default is cha.
algo: cha
# Inspect exported functions, default is false. Set to true if no external program/library imports your code. # Inspect exported functions, default is false. Set to true if no external program/library imports your code.
# XXX: if you enable this setting, unparam will report a lot of false-positives in text editors: # XXX: if you enable this setting, unparam will report a lot of false-positives in text editors:
# if it's called for subdir of a project it can't find external interfaces. All text editor integrations # if it's called for subdir of a project it can't find external interfaces. All text editor integrations

4
pkg/golinters/unparam.go
View File

@ -22,6 +22,10 @@ func (Unparam) Desc() string {
func (lint Unparam) Run(ctx context.Context, lintCtx *linter.Context) ([]result.Issue, error) { func (lint Unparam) Run(ctx context.Context, lintCtx *linter.Context) ([]result.Issue, error) {
us := &lintCtx.Settings().Unparam us := &lintCtx.Settings().Unparam
if us.Algo != "cha" {
lintCtx.Log.Warnf("`linters-settings.unparam.algo` isn't supported by the newest `unparam`")
}
c := &check.Checker{} c := &check.Checker{}
c.CheckExportedFuncs(us.CheckExported) c.CheckExportedFuncs(us.CheckExported)
c.Packages(lintCtx.Packages) c.Packages(lintCtx.Packages)