From b407bb8fd0706e6365dcc9ca25472fabac549205 Mon Sep 17 00:00:00 2001
From: Ludovic Fernandez <ldez@users.noreply.github.com>
Date: Wed, 24 Feb 2021 09:07:54 +0100
Subject: [PATCH] revive: add rule name in message. (#1772)
---
pkg/golinters/revive.go | 2 +-
test/testdata/revive.go | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/pkg/golinters/revive.go b/pkg/golinters/revive.go
index c1d4bbae..0420731f 100644
--- a/pkg/golinters/revive.go
+++ b/pkg/golinters/revive.go
@@ -109,7 +109,7 @@ func NewRevive(cfg *config.ReviveSettings) *goanalysis.Linter {
for i := range results {
issues = append(issues, goanalysis.NewIssue(&result.Issue{
Severity: string(results[i].Severity),
- Text: fmt.Sprintf("%q", results[i].Failure.Failure),
+ Text: fmt.Sprintf("%s: %s", results[i].RuleName, results[i].Failure.Failure),
Pos: token.Position{
Filename: results[i].Position.Start.Filename,
Line: results[i].Position.Start.Line,
diff --git a/test/testdata/revive.go b/test/testdata/revive.go
index 224880b3..83e3d18d 100644
--- a/test/testdata/revive.go
+++ b/test/testdata/revive.go
@@ -7,7 +7,7 @@ import "time"
func testRevive(t *time.Duration) error {
if t == nil {
return nil
- } else { // ERROR "if block ends with a return statement, so drop this else and outdent its block"
+ } else { // ERROR "indent-error-flow: if block ends with a return statement, .*"
return nil
}
}