From ae5152c0241ea62aa69521d6a1afc857e4fa1344 Mon Sep 17 00:00:00 2001
From: golangci <dev@golangci.com>
Date: Tue, 29 May 2018 14:15:09 +0300
Subject: [PATCH] fix GOROOT after cross-compilation
---
pkg/commands/run.go | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/pkg/commands/run.go b/pkg/commands/run.go
index b5a5ea0d..0f1f6551 100644
--- a/pkg/commands/run.go
+++ b/pkg/commands/run.go
@@ -9,6 +9,7 @@ import (
"io/ioutil"
"log"
"os"
+ "os/exec"
"runtime"
"strings"
"time"
@@ -175,7 +176,31 @@ func buildSSAProgram(ctx context.Context, lprog *loader.Program) *ssa.Program {
return ssaProg
}
+func discoverGoRoot() (string, error) {
+ goroot := os.Getenv("GOROOT")
+ if goroot != "" {
+ return goroot, nil
+ }
+
+ output, err := exec.Command("go", "env", "GOROOT").Output()
+ if err != nil {
+ return "", fmt.Errorf("can't execute go env GOROOT: %s", err)
+ }
+
+ return strings.TrimSpace(string(output)), nil
+}
+
func buildLintCtx(ctx context.Context, linters []pkg.Linter, cfg *config.Config) (*golinters.Context, error) {
+ // Set GOROOT to have working cross-compilation: cross-compiled binaries
+ // have invalid GOROOT. XXX: can't use runtime.GOROOT().
+ goroot, err := discoverGoRoot()
+ if err != nil {
+ return nil, fmt.Errorf("can't discover GOROOT: %s", err)
+ }
+ os.Setenv("GOROOT", goroot)
+ build.Default.GOROOT = goroot
+ logrus.Infof("set GOROOT=%q", goroot)
+
args := cfg.Run.Args
if len(args) == 0 {
args = []string{"./..."}