govet: add directive and slog passes (#4028)

Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
This commit is contained in:
Mitsuo Heijo 2023-08-19 20:47:35 +09:00 committed by GitHub
parent 2741ab2ac0
commit a5eaf9fe30
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions

View File

@ -1063,6 +1063,7 @@ linters-settings:
- copylocks - copylocks
- deepequalerrors - deepequalerrors
- defers - defers
- directive
- errorsas - errorsas
- fieldalignment - fieldalignment
- findcall - findcall
@ -1078,6 +1079,7 @@ linters-settings:
- shadow - shadow
- shift - shift
- sigchanyzer - sigchanyzer
- slog
- sortslice - sortslice
- stdmethods - stdmethods
- stringintconv - stringintconv
@ -1107,6 +1109,8 @@ linters-settings:
- composites - composites
- copylocks - copylocks
- deepequalerrors - deepequalerrors
- defers
- directive
- errorsas - errorsas
- fieldalignment - fieldalignment
- findcall - findcall
@ -1122,6 +1126,7 @@ linters-settings:
- shadow - shadow
- shift - shift
- sigchanyzer - sigchanyzer
- slog
- sortslice - sortslice
- stdmethods - stdmethods
- stringintconv - stringintconv

View File

@ -15,6 +15,7 @@ import (
_ "golang.org/x/tools/go/analysis/passes/ctrlflow" // unused, internal analyzer _ "golang.org/x/tools/go/analysis/passes/ctrlflow" // unused, internal analyzer
"golang.org/x/tools/go/analysis/passes/deepequalerrors" "golang.org/x/tools/go/analysis/passes/deepequalerrors"
"golang.org/x/tools/go/analysis/passes/defers" "golang.org/x/tools/go/analysis/passes/defers"
"golang.org/x/tools/go/analysis/passes/directive"
"golang.org/x/tools/go/analysis/passes/errorsas" "golang.org/x/tools/go/analysis/passes/errorsas"
"golang.org/x/tools/go/analysis/passes/fieldalignment" "golang.org/x/tools/go/analysis/passes/fieldalignment"
"golang.org/x/tools/go/analysis/passes/findcall" "golang.org/x/tools/go/analysis/passes/findcall"
@ -32,6 +33,7 @@ import (
"golang.org/x/tools/go/analysis/passes/shadow" "golang.org/x/tools/go/analysis/passes/shadow"
"golang.org/x/tools/go/analysis/passes/shift" "golang.org/x/tools/go/analysis/passes/shift"
"golang.org/x/tools/go/analysis/passes/sigchanyzer" "golang.org/x/tools/go/analysis/passes/sigchanyzer"
"golang.org/x/tools/go/analysis/passes/slog"
"golang.org/x/tools/go/analysis/passes/sortslice" "golang.org/x/tools/go/analysis/passes/sortslice"
"golang.org/x/tools/go/analysis/passes/stdmethods" "golang.org/x/tools/go/analysis/passes/stdmethods"
"golang.org/x/tools/go/analysis/passes/stringintconv" "golang.org/x/tools/go/analysis/passes/stringintconv"
@ -62,6 +64,7 @@ var (
copylock.Analyzer, copylock.Analyzer,
deepequalerrors.Analyzer, deepequalerrors.Analyzer,
defers.Analyzer, defers.Analyzer,
directive.Analyzer,
errorsas.Analyzer, errorsas.Analyzer,
fieldalignment.Analyzer, fieldalignment.Analyzer,
findcall.Analyzer, findcall.Analyzer,
@ -77,6 +80,7 @@ var (
shadow.Analyzer, shadow.Analyzer,
shift.Analyzer, shift.Analyzer,
sigchanyzer.Analyzer, sigchanyzer.Analyzer,
slog.Analyzer,
sortslice.Analyzer, sortslice.Analyzer,
stdmethods.Analyzer, stdmethods.Analyzer,
stringintconv.Analyzer, stringintconv.Analyzer,
@ -91,7 +95,7 @@ var (
unusedwrite.Analyzer, unusedwrite.Analyzer,
} }
// https://github.com/golang/go/blob/9f834a559c9ed6cdf883e29b36e21e5f956df74f/src/cmd/vet/main.go#L46-L76 // https://github.com/golang/go/blob/c19c4c566c63818dfd059b352e52c4710eecf14d/src/cmd/vet/main.go#L47-L78
defaultAnalyzers = []*analysis.Analyzer{ defaultAnalyzers = []*analysis.Analyzer{
asmdecl.Analyzer, asmdecl.Analyzer,
assign.Analyzer, assign.Analyzer,
@ -101,6 +105,7 @@ var (
cgocall.Analyzer, cgocall.Analyzer,
composite.Analyzer, composite.Analyzer,
copylock.Analyzer, copylock.Analyzer,
directive.Analyzer,
errorsas.Analyzer, errorsas.Analyzer,
framepointer.Analyzer, framepointer.Analyzer,
httpresponse.Analyzer, httpresponse.Analyzer,
@ -111,6 +116,7 @@ var (
printf.Analyzer, printf.Analyzer,
shift.Analyzer, shift.Analyzer,
sigchanyzer.Analyzer, sigchanyzer.Analyzer,
slog.Analyzer,
stdmethods.Analyzer, stdmethods.Analyzer,
stringintconv.Analyzer, stringintconv.Analyzer,
structtag.Analyzer, structtag.Analyzer,