eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Added support for only specifying default severity (#1396)

Browse Source
This commit is contained in:
ac-rappi 2020-10-19 01:21:46 -03:00 committed by GitHub
parent e4346a8bd6
commit 9b3ba431f1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/result/processors/severity_rules.go
View File

@ -57,7 +57,7 @@ func createSeverityRules(rules []SeverityRule, prefix string) []severityRule {
} }
func (p SeverityRules) Process(issues []result.Issue) ([]result.Issue, error) { func (p SeverityRules) Process(issues []result.Issue) ([]result.Issue, error) {
if len(p.rules) == 0 { if len(p.rules) == 0 && p.defaultSeverity == "" {
return issues, nil return issues, nil
} }
return transformIssues(issues, func(i *result.Issue) *result.Issue { return transformIssues(issues, func(i *result.Issue) *result.Issue {

31
pkg/result/processors/severity_rules_test.go
View File

@ -132,6 +132,37 @@ func TestSeverityRulesText(t *testing.T) {
assert.Equal(t, texts, processedTexts) assert.Equal(t, texts, processedTexts)
} }
func TestSeverityRulesOnlyDefault(t *testing.T) {
lineCache := fsutils.NewLineCache(fsutils.NewFileCache())
log := report.NewLogWrapper(logutils.NewStderrLog(""), &report.Data{})
p := NewSeverityRules("info", []SeverityRule{}, lineCache, log)
cases := []issueTestCase{
{Path: "ssl.go", Text: "ssl", Linter: "gosec"},
{Path: "empty.go", Text: "empty", Linter: "empty"},
}
var issues []result.Issue
for _, c := range cases {
issues = append(issues, newIssueFromIssueTestCase(c))
}
processedIssues := process(t, p, issues...)
var resultingCases []issueTestCase
for _, i := range processedIssues {
resultingCases = append(resultingCases, issueTestCase{
Path: i.FilePath(),
Linter: i.FromLinter,
Text: i.Text,
Line: i.Line(),
Severity: i.Severity,
})
}
expectedCases := []issueTestCase{
{Path: "ssl.go", Text: "ssl", Linter: "gosec", Severity: "info"},
{Path: "empty.go", Text: "empty", Linter: "empty", Severity: "info"},
}
assert.Equal(t, expectedCases, resultingCases)
}
func TestSeverityRulesEmpty(t *testing.T) { func TestSeverityRulesEmpty(t *testing.T) {
processAssertSame(t, NewSeverityRules("", nil, nil, nil), newIssueFromTextTestCase("test")) processAssertSame(t, NewSeverityRules("", nil, nil, nil), newIssueFromTextTestCase("test"))
} }