eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Fix #122: don't crash govet on tests-only packages

Browse Source
This commit is contained in:
Denis Isaev 2018-06-19 16:32:36 +03:00
parent ebbfc26e88
commit 93311aee9b
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.travis.yml
View File

@ -7,6 +7,7 @@ script: make check_generated test
after_success: after_success:
- test -n "$TRAVIS_TAG" && docker login -u="$DOCKER_USERNAME" -p="$DOCKER_PASSWORD" - test -n "$TRAVIS_TAG" && docker login -u="$DOCKER_USERNAME" -p="$DOCKER_PASSWORD"
- echo "travis go version='$TRAVIS_GO_VERSION'"
# needed for the docker pipe # needed for the docker pipe
services: services:
@ -18,4 +19,4 @@ deploy:
script: curl -sL https://git.io/goreleaser | bash script: curl -sL https://git.io/goreleaser | bash
on: on:
tags: true tags: true
condition: $TRAVIS_GO_VERSION =~ ^1\.10\.[0-9]+$ condition: $TRAVIS_GO_VERSION =~ ^1\.10\.

6
pkg/golinters/govet.go
View File

@ -76,6 +76,9 @@ func (g Govet) runOnInstalledPackages(ctx context.Context, lintCtx *linter.Conte
astFiles = append(astFiles, af.F) astFiles = append(astFiles, af.F)
fset = af.Fset fset = af.Fset
} }
if len(astFiles) == 0 {
continue
}
issues, err := govetAPI.Analyze(astFiles, fset, nil, issues, err := govetAPI.Analyze(astFiles, fset, nil,
lintCtx.Settings().Govet.CheckShadowing) lintCtx.Settings().Govet.CheckShadowing)
if err != nil { if err != nil {
@ -216,6 +219,9 @@ func (g Govet) runOnSourcePackages(ctx context.Context, lintCtx *linter.Context)
// TODO: check .S asm files: govet can do it if pass dirs // TODO: check .S asm files: govet can do it if pass dirs
var govetIssues []govetAPI.Issue var govetIssues []govetAPI.Issue
for _, pkg := range lintCtx.Program.InitialPackages() { for _, pkg := range lintCtx.Program.InitialPackages() {
if len(pkg.Files) == 0 {
continue
}
issues, err := govetAPI.Analyze(pkg.Files, lintCtx.Program.Fset, pkg, issues, err := govetAPI.Analyze(pkg.Files, lintCtx.Program.Fset, pkg,
lintCtx.Settings().Govet.CheckShadowing) lintCtx.Settings().Govet.CheckShadowing)
if err != nil { if err != nil {