eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

unused: remove exported-is-used option (#4890)

Browse Source
This commit is contained in:
Ludovic Fernandez 2024-08-01 01:34:04 +02:00 committed by GitHub
parent 5536bb5ce7
commit 78a738f7cb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
jsonschema/golangci.next.jsonschema.json
View File

@ -3233,11 +3233,6 @@
"type": "boolean", "type": "boolean",
"default": false "default": false
}, },
"exported-is-used": {
"description": "",
"type": "boolean",
"default": true
},
"exported-fields-are-used": { "exported-fields-are-used": {
"description": "", "description": "",
"type": "boolean", "type": "boolean",

2
pkg/config/linters_settings.go
View File

@ -948,7 +948,7 @@ type UnparamSettings struct {
type UnusedSettings struct { type UnusedSettings struct {
FieldWritesAreUses bool `mapstructure:"field-writes-are-uses"` FieldWritesAreUses bool `mapstructure:"field-writes-are-uses"`
PostStatementsAreReads bool `mapstructure:"post-statements-are-reads"` PostStatementsAreReads bool `mapstructure:"post-statements-are-reads"`
ExportedIsUsed bool `mapstructure:"exported-is-used"` ExportedIsUsed bool `mapstructure:"exported-is-used"` // Deprecated
ExportedFieldsAreUsed bool `mapstructure:"exported-fields-are-used"` ExportedFieldsAreUsed bool `mapstructure:"exported-fields-are-used"`
ParametersAreUsed bool `mapstructure:"parameters-are-used"` ParametersAreUsed bool `mapstructure:"parameters-are-used"`
LocalVariablesAreUsed bool `mapstructure:"local-variables-are-used"` LocalVariablesAreUsed bool `mapstructure:"local-variables-are-used"`

5
pkg/config/loader.go
View File

@ -433,6 +433,11 @@ func (l *Loader) handleLinterOptionDeprecations() {
l.log.Warnf("The configuration option `linters.stylecheck.go` is deprecated, please use global `run.go`.") l.log.Warnf("The configuration option `linters.stylecheck.go` is deprecated, please use global `run.go`.")
} }
// Deprecated since v1.60.0
if !l.cfg.LintersSettings.Unused.ExportedIsUsed {
l.log.Warnf("The configuration option `linters.unused.exported-is-used` is deprecated.")
}
// Deprecated since v1.58.0 // Deprecated since v1.58.0
if l.cfg.LintersSettings.SlogLint.ContextOnly { if l.cfg.LintersSettings.SlogLint.ContextOnly {
l.log.Warnf("The configuration option `linters.sloglint.context-only` is deprecated, please use `linters.sloglint.context`.") l.log.Warnf("The configuration option `linters.sloglint.context-only` is deprecated, please use `linters.sloglint.context`.")

12
pkg/golinters/unused/unused.go
View File

@ -90,11 +90,13 @@ func getUnusedResults(pass *analysis.Pass, settings *config.UnusedSettings) unus
opts := unused.Options{ opts := unused.Options{
FieldWritesAreUses: settings.FieldWritesAreUses, FieldWritesAreUses: settings.FieldWritesAreUses,
PostStatementsAreReads: settings.PostStatementsAreReads, PostStatementsAreReads: settings.PostStatementsAreReads,
ExportedIsUsed: settings.ExportedIsUsed, // Related to https://github.com/golangci/golangci-lint/issues/4218
ExportedFieldsAreUsed: settings.ExportedFieldsAreUsed, // https://github.com/dominikh/go-tools/issues/1474#issuecomment-1850760813
ParametersAreUsed: settings.ParametersAreUsed, ExportedIsUsed: true,
LocalVariablesAreUsed: settings.LocalVariablesAreUsed, ExportedFieldsAreUsed: settings.ExportedFieldsAreUsed,
GeneratedIsUsed: settings.GeneratedIsUsed, ParametersAreUsed: settings.ParametersAreUsed,
LocalVariablesAreUsed: settings.LocalVariablesAreUsed,
GeneratedIsUsed: settings.GeneratedIsUsed,
} }
// ref: https://github.com/dominikh/go-tools/blob/4ec1f474ca6c0feb8e10a8fcca4ab95f5b5b9881/internal/cmd/unused/unused.go#L68 // ref: https://github.com/dominikh/go-tools/blob/4ec1f474ca6c0feb8e10a8fcca4ab95f5b5b9881/internal/cmd/unused/unused.go#L68