From 65981c2a0be15a77a19a85fdb28e01bff43e7276 Mon Sep 17 00:00:00 2001 From: Dan Kortschak Date: Wed, 22 Apr 2020 08:22:32 +0930 Subject: [PATCH 1/2] doc: provide instructions for from-source installation --- README.md | 10 ++++------ README.tmpl.md | 10 ++++------ 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/README.md b/README.md index 9a86b13f..6e6f392a 100644 --- a/README.md +++ b/README.md @@ -108,13 +108,11 @@ docker run --rm -v $(pwd):/app -w /app golangci/golangci-lint:v1.24.0 golangci-l ### Go -Please, do not install `golangci-lint` by `go get`: +Go source installations are supported for the two most recent Go releases. -1. [`go.mod`](https://github.com/golangci/golangci-lint/blob/master/go.mod) replacement directive doesn't apply. It means you will be using patched version of `golangci-lint`. -2. it's much slower than binary installation -3. its stability depends on your Go version (e.g. on [this compiler Go <= 1.12 bug](https://github.com/golang/go/issues/29612)). -4. it's not guaranteed to work: e.g. we've encountered a lot of issues with Go modules hashes. -5. it allows installation from `master` branch which can't be considered stable. +```bash +GO111MODULE=on go get github.com/golangci/golangci-lint/cmd/golangci-lint +``` ## Trusted By diff --git a/README.tmpl.md b/README.tmpl.md index 1e2cfa1e..13ad1aae 100644 --- a/README.tmpl.md +++ b/README.tmpl.md @@ -108,13 +108,11 @@ docker run --rm -v $(pwd):/app -w /app golangci/golangci-lint:{{.LatestVersion}} ### Go -Please, do not install `golangci-lint` by `go get`: +Go source installations are supported for the two most recent Go releases. -1. [`go.mod`](https://github.com/golangci/golangci-lint/blob/master/go.mod) replacement directive doesn't apply. It means you will be using patched version of `golangci-lint`. -2. it's much slower than binary installation -3. its stability depends on your Go version (e.g. on [this compiler Go <= 1.12 bug](https://github.com/golang/go/issues/29612)). -4. it's not guaranteed to work: e.g. we've encountered a lot of issues with Go modules hashes. -5. it allows installation from `master` branch which can't be considered stable. +```bash +GO111MODULE=on go get github.com/golangci/golangci-lint/cmd/golangci-lint +``` ## Trusted By From f13612b04cec578ec20ccd3b541345a376bdf5ce Mon Sep 17 00:00:00 2001 From: Dan Kortschak Date: Wed, 22 Apr 2020 11:15:37 +0930 Subject: [PATCH 2/2] doc: address pr comment --- README.md | 2 +- README.tmpl.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 6e6f392a..0207099c 100644 --- a/README.md +++ b/README.md @@ -111,7 +111,7 @@ docker run --rm -v $(pwd):/app -w /app golangci/golangci-lint:v1.24.0 golangci-l Go source installations are supported for the two most recent Go releases. ```bash -GO111MODULE=on go get github.com/golangci/golangci-lint/cmd/golangci-lint +GO111MODULE=on go get github.com/golangci/golangci-lint/cmd/golangci-lint@v1.24.0 ``` ## Trusted By diff --git a/README.tmpl.md b/README.tmpl.md index 13ad1aae..f0da7247 100644 --- a/README.tmpl.md +++ b/README.tmpl.md @@ -111,7 +111,7 @@ docker run --rm -v $(pwd):/app -w /app golangci/golangci-lint:{{.LatestVersion}} Go source installations are supported for the two most recent Go releases. ```bash -GO111MODULE=on go get github.com/golangci/golangci-lint/cmd/golangci-lint +GO111MODULE=on go get github.com/golangci/golangci-lint/cmd/golangci-lint@{{.LatestVersion}} ``` ## Trusted By