diff --git a/.golangci.yml b/.golangci.yml
index 937488d6..a0146f2c 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -17,13 +17,15 @@ linters-settings:
logger:
deny:
# logging is allowed only by logutils.Log,
- # logrus is allowed to use only in logutils package.
- pkg: "github.com/sirupsen/logrus"
desc: logging is allowed only by logutils.Log.
- pkg: "github.com/pkg/errors"
desc: Should be replaced by standard lib errors package.
- pkg: "github.com/instana/testify"
desc: It's a fork of github.com/stretchr/testify.
+ files:
+ # logrus is allowed to use only in logutils package.
+ - "!**/pkg/logutils/**.go"
dupl:
threshold: 100
funlen:
@@ -86,10 +88,12 @@ linters-settings:
line-length: 140
misspell:
locale: US
+ ignore-words:
+ - "importas" # linter name
nolintlint:
allow-unused: false # report any unused nolint directives
- require-explanation: false # don't require an explanation for nolint directives
- require-specific: false # don't require nolint directives to be specific about which linter is being skipped
+ require-explanation: true # require an explanation for nolint directives
+ require-specific: true # require nolint directives to be specific about which linter is being skipped
revive:
rules:
- name: unexported-return
@@ -144,7 +148,9 @@ issues:
exclude-rules:
- path: _test\.go
linters:
+ - dupl
- gomnd
+ - lll
- path: pkg/golinters/errcheck.go
linters: [staticcheck]
@@ -158,6 +164,10 @@ issues:
- path: pkg/golinters/govet.go
text: "SA1019: cfg.CheckShadowing is deprecated: the linter should be enabled inside `Enable`."
+ - path: pkg/golinters
+ linters:
+ - dupl
+
- path: pkg/golinters/gofumpt.go
linters: [staticcheck]
text: "SA1019: settings.LangVersion is deprecated: use the global `run.go` instead."
diff --git a/pkg/commands/flagsets.go b/pkg/commands/flagsets.go
index be541d12..af5c351c 100644
--- a/pkg/commands/flagsets.go
+++ b/pkg/commands/flagsets.go
@@ -80,7 +80,7 @@ func setupOutputFlagSet(v *viper.Viper, fs *pflag.FlagSet) {
internal.AddFlagAndBind(v, fs, fs.Bool, "show-stats", "output.show-stats", false, color.GreenString("Show statistics per linter"))
}
-//nolint:gomnd
+//nolint:gomnd // magic numbers here is ok
func setupIssuesFlagSet(v *viper.Viper, fs *pflag.FlagSet) {
internal.AddHackedStringSliceP(fs, "exclude", "e", color.GreenString("Exclude issue by regexp"))
internal.AddFlagAndBind(v, fs, fs.Bool, "exclude-use-default", "issues.exclude-use-default", true,
diff --git a/pkg/golinters/dogsled.go b/pkg/golinters/dogsled.go
index 79502fe8..de567ce7 100644
--- a/pkg/golinters/dogsled.go
+++ b/pkg/golinters/dogsled.go
@@ -16,7 +16,6 @@ import (
const dogsledName = "dogsled"
-//nolint:dupl
func NewDogsled(settings *config.DogsledSettings) *goanalysis.Linter {
var mu sync.Mutex
var resIssues []goanalysis.Issue
diff --git a/pkg/golinters/dupl.go b/pkg/golinters/dupl.go
index 5d772a5f..eec51eab 100644
--- a/pkg/golinters/dupl.go
+++ b/pkg/golinters/dupl.go
@@ -17,7 +17,6 @@ import (
const duplName = "dupl"
-//nolint:dupl
func NewDupl(settings *config.DuplSettings) *goanalysis.Linter {
var mu sync.Mutex
var resIssues []goanalysis.Issue
diff --git a/pkg/golinters/forbidigo.go b/pkg/golinters/forbidigo.go
index 6aced292..797484ba 100644
--- a/pkg/golinters/forbidigo.go
+++ b/pkg/golinters/forbidigo.go
@@ -16,7 +16,6 @@ import (
const forbidigoName = "forbidigo"
-//nolint:dupl
func NewForbidigo(settings *config.ForbidigoSettings) *goanalysis.Linter {
var mu sync.Mutex
var resIssues []goanalysis.Issue
diff --git a/pkg/golinters/funlen.go b/pkg/golinters/funlen.go
index 8def9c1f..d421e174 100644
--- a/pkg/golinters/funlen.go
+++ b/pkg/golinters/funlen.go
@@ -16,7 +16,6 @@ import (
const funlenName = "funlen"
-//nolint:dupl
func NewFunlen(settings *config.FunlenSettings) *goanalysis.Linter {
var mu sync.Mutex
var resIssues []goanalysis.Issue
diff --git a/pkg/golinters/goanalysis/runner.go b/pkg/golinters/goanalysis/runner.go
index 8243c345..b75e3fa0 100644
--- a/pkg/golinters/goanalysis/runner.go
+++ b/pkg/golinters/goanalysis/runner.go
@@ -177,10 +177,9 @@ func (r *runner) buildActionFactDeps(act *action, a *analysis.Analyzer, pkg *pac
}
}
-//nolint:gocritic
func (r *runner) prepareAnalysis(pkgs []*packages.Package,
analyzers []*analysis.Analyzer,
-) (map[*packages.Package]bool, []*action, []*action) {
+) (initialPkgs map[*packages.Package]bool, allActions, roots []*action) {
// Construct the action graph.
// Each graph node (action) is one unit of analysis.
@@ -200,13 +199,13 @@ func (r *runner) prepareAnalysis(pkgs []*packages.Package,
actions := make(map[actKey]*action, totalActionsCount)
actAlloc := newActionAllocator(totalActionsCount)
- initialPkgs := make(map[*packages.Package]bool, len(pkgs))
+ initialPkgs = make(map[*packages.Package]bool, len(pkgs))
for _, pkg := range pkgs {
initialPkgs[pkg] = true
}
// Build nodes for initial packages.
- roots := make([]*action, 0, len(pkgs)*len(analyzers))
+ roots = make([]*action, 0, len(pkgs)*len(analyzers))
for _, a := range analyzers {
for _, pkg := range pkgs {
root := r.makeAction(a, pkg, initialPkgs, actions, actAlloc)
@@ -215,7 +214,7 @@ func (r *runner) prepareAnalysis(pkgs []*packages.Package,
}
}
- allActions := maps.Values(actions)
+ allActions = maps.Values(actions)
debugf("Built %d actions", len(actions))
@@ -281,7 +280,6 @@ func (r *runner) analyze(pkgs []*packages.Package, analyzers []*analysis.Analyze
return rootActions
}
-//nolint:nakedret
func extractDiagnostics(roots []*action) (retDiags []Diagnostic, retErrors []error) {
extracted := make(map[*action]bool)
var extract func(*action)
@@ -338,5 +336,5 @@ func extractDiagnostics(roots []*action) (retDiags []Diagnostic, retErrors []err
}
}
visitAll(roots)
- return
+ return retDiags, retErrors
}
diff --git a/pkg/golinters/goanalysis/runners.go b/pkg/golinters/goanalysis/runners.go
index c5a0b612..b832fc32 100644
--- a/pkg/golinters/goanalysis/runners.go
+++ b/pkg/golinters/goanalysis/runners.go
@@ -184,10 +184,9 @@ func saveIssuesToCache(allPkgs []*packages.Package, pkgsFromCache map[*packages.
issuesCacheDebugf("Saved %d issues from %d packages to cache in %s", savedIssuesCount, len(allPkgs), time.Since(startedAt))
}
-//nolint:gocritic
func loadIssuesFromCache(pkgs []*packages.Package, lintCtx *linter.Context,
analyzers []*analysis.Analyzer,
-) ([]result.Issue, map[*packages.Package]bool) {
+) (issuesFromCache []result.Issue, pkgsFromCache map[*packages.Package]bool) {
startedAt := time.Now()
lintResKey := getIssuesCacheKey(analyzers)
@@ -221,17 +220,18 @@ func loadIssuesFromCache(pkgs []*packages.Package, lintCtx *linter.Context,
}
issues := make([]result.Issue, 0, len(pkgIssues))
- for _, i := range pkgIssues {
+ for i := range pkgIssues {
+ issue := &pkgIssues[i]
issues = append(issues, result.Issue{
- FromLinter: i.FromLinter,
- Text: i.Text,
- Severity: i.Severity,
- Pos: i.Pos,
- LineRange: i.LineRange,
- Replacement: i.Replacement,
+ FromLinter: issue.FromLinter,
+ Text: issue.Text,
+ Severity: issue.Severity,
+ Pos: issue.Pos,
+ LineRange: issue.LineRange,
+ Replacement: issue.Replacement,
Pkg: pkg,
- ExpectNoLint: i.ExpectNoLint,
- ExpectedNoLintLinter: i.ExpectedNoLintLinter,
+ ExpectNoLint: issue.ExpectNoLint,
+ ExpectedNoLintLinter: issue.ExpectedNoLintLinter,
})
}
cacheRes.issues = issues
@@ -246,13 +246,12 @@ func loadIssuesFromCache(pkgs []*packages.Package, lintCtx *linter.Context,
wg.Wait()
loadedIssuesCount := 0
- var issues []result.Issue
- pkgsFromCache := map[*packages.Package]bool{}
+ pkgsFromCache = map[*packages.Package]bool{}
for pkg, cacheRes := range pkgToCacheRes {
if cacheRes.loadErr == nil {
loadedIssuesCount += len(cacheRes.issues)
pkgsFromCache[pkg] = true
- issues = append(issues, cacheRes.issues...)
+ issuesFromCache = append(issuesFromCache, cacheRes.issues...)
issuesCacheDebugf("Loaded package %s issues (%d) from cache", pkg, len(cacheRes.issues))
} else {
issuesCacheDebugf("Didn't load package %s issues from cache: %s", pkg, cacheRes.loadErr)
@@ -260,7 +259,7 @@ func loadIssuesFromCache(pkgs []*packages.Package, lintCtx *linter.Context,
}
issuesCacheDebugf("Loaded %d issues from cache in %s, analyzing %d/%d packages",
loadedIssuesCount, time.Since(startedAt), len(pkgs)-len(pkgsFromCache), len(pkgs))
- return issues, pkgsFromCache
+ return issuesFromCache, pkgsFromCache
}
func analyzersHashID(analyzers []*analysis.Analyzer) string {
diff --git a/pkg/golinters/gocognit.go b/pkg/golinters/gocognit.go
index 406d34ed..f5cff840 100644
--- a/pkg/golinters/gocognit.go
+++ b/pkg/golinters/gocognit.go
@@ -16,7 +16,6 @@ import (
const gocognitName = "gocognit"
-//nolint:dupl
func NewGocognit(settings *config.GocognitSettings) *goanalysis.Linter {
var mu sync.Mutex
var resIssues []goanalysis.Issue
diff --git a/pkg/golinters/goconst.go b/pkg/golinters/goconst.go
index b5188527..204e2496 100644
--- a/pkg/golinters/goconst.go
+++ b/pkg/golinters/goconst.go
@@ -15,7 +15,6 @@ import (
const goconstName = "goconst"
-//nolint:dupl
func NewGoconst(settings *config.GoConstSettings) *goanalysis.Linter {
var mu sync.Mutex
var resIssues []goanalysis.Issue
diff --git a/pkg/golinters/gocyclo.go b/pkg/golinters/gocyclo.go
index b502623b..63aefb09 100644
--- a/pkg/golinters/gocyclo.go
+++ b/pkg/golinters/gocyclo.go
@@ -15,7 +15,6 @@ import (
const gocycloName = "gocyclo"
-//nolint:dupl
func NewGocyclo(settings *config.GoCycloSettings) *goanalysis.Linter {
var mu sync.Mutex
var resIssues []goanalysis.Issue
diff --git a/pkg/golinters/godox.go b/pkg/golinters/godox.go
index 95581041..208bade5 100644
--- a/pkg/golinters/godox.go
+++ b/pkg/golinters/godox.go
@@ -16,7 +16,6 @@ import (
const godoxName = "godox"
-//nolint:dupl
func NewGodox(settings *config.GodoxSettings) *goanalysis.Linter {
var mu sync.Mutex
var resIssues []goanalysis.Issue
diff --git a/pkg/golinters/gofmt_common.go b/pkg/golinters/gofmt_common.go
index 6b7184d6..afa7afbf 100644
--- a/pkg/golinters/gofmt_common.go
+++ b/pkg/golinters/gofmt_common.go
@@ -133,8 +133,8 @@ func (p *hunkChangesParser) handleDeletedLines(deletedLines []diffLine, addedLin
}
if len(addedLines) != 0 {
- //nolint:gocritic
- change.Replacement.NewLines = append(p.replacementLinesToPrepend, addedLines...)
+ change.Replacement.NewLines = append([]string{}, p.replacementLinesToPrepend...)
+ change.Replacement.NewLines = append(change.Replacement.NewLines, addedLines...)
if len(p.replacementLinesToPrepend) != 0 {
p.replacementLinesToPrepend = nil
}
diff --git a/pkg/golinters/importas.go b/pkg/golinters/importas.go
index b06aec7a..a426333d 100644
--- a/pkg/golinters/importas.go
+++ b/pkg/golinters/importas.go
@@ -5,7 +5,7 @@ import (
"strconv"
"strings"
- "github.com/julz/importas" //nolint:misspell
+ "github.com/julz/importas"
"golang.org/x/tools/go/analysis"
"github.com/golangci/golangci-lint/pkg/config"
@@ -26,7 +26,7 @@ func NewImportAs(settings *config.ImportAsSettings) *goanalysis.Linter {
return
}
if len(settings.Alias) == 0 {
- lintCtx.Log.Infof("importas settings found, but no aliases listed. List aliases under alias: key.") //nolint:misspell
+ lintCtx.Log.Infof("importas settings found, but no aliases listed. List aliases under alias: key.")
}
if err := analyzer.Flags.Set("no-unaliased", strconv.FormatBool(settings.NoUnaliased)); err != nil {
diff --git a/pkg/golinters/lll.go b/pkg/golinters/lll.go
index 61498087..84ce61a9 100644
--- a/pkg/golinters/lll.go
+++ b/pkg/golinters/lll.go
@@ -22,7 +22,6 @@ const lllName = "lll"
const goCommentDirectivePrefix = "//go:"
-//nolint:dupl
func NewLLL(settings *config.LllSettings) *goanalysis.Linter {
var mu sync.Mutex
var resIssues []goanalysis.Issue
diff --git a/pkg/golinters/makezero.go b/pkg/golinters/makezero.go
index a9828629..7a14c8e0 100644
--- a/pkg/golinters/makezero.go
+++ b/pkg/golinters/makezero.go
@@ -15,7 +15,6 @@ import (
const makezeroName = "makezero"
-//nolint:dupl
func NewMakezero(settings *config.MakezeroSettings) *goanalysis.Linter {
var mu sync.Mutex
var resIssues []goanalysis.Issue
diff --git a/pkg/golinters/nestif.go b/pkg/golinters/nestif.go
index 12ad69ec..4125ad9a 100644
--- a/pkg/golinters/nestif.go
+++ b/pkg/golinters/nestif.go
@@ -15,7 +15,6 @@ import (
const nestifName = "nestif"
-//nolint:dupl
func NewNestif(settings *config.NestifSettings) *goanalysis.Linter {
var mu sync.Mutex
var resIssues []goanalysis.Issue
diff --git a/pkg/golinters/nolintlint.go b/pkg/golinters/nolintlint.go
index ae372ab7..7000620d 100644
--- a/pkg/golinters/nolintlint.go
+++ b/pkg/golinters/nolintlint.go
@@ -16,7 +16,6 @@ import (
const NoLintLintName = "nolintlint"
-//nolint:dupl
func NewNoLintLint(settings *config.NoLintLintSettings) *goanalysis.Linter {
var mu sync.Mutex
var resIssues []goanalysis.Issue
diff --git a/pkg/golinters/nolintlint/nolintlint.go b/pkg/golinters/nolintlint/nolintlint.go
index aadc7eb6..1bce5ef5 100644
--- a/pkg/golinters/nolintlint/nolintlint.go
+++ b/pkg/golinters/nolintlint/nolintlint.go
@@ -156,7 +156,7 @@ var (
trailingBlankExplanation = regexp.MustCompile(`\s*(//\s*)?$`)
)
-//nolint:funlen,gocyclo
+//nolint:funlen,gocyclo // the function is going to be refactored in the future
func (l Linter) Run(fset *token.FileSet, nodes ...ast.Node) ([]Issue, error) {
var issues []Issue
diff --git a/pkg/golinters/nolintlint/nolintlint_test.go b/pkg/golinters/nolintlint/nolintlint_test.go
index 0400e8df..a483c7ea 100644
--- a/pkg/golinters/nolintlint/nolintlint_test.go
+++ b/pkg/golinters/nolintlint/nolintlint_test.go
@@ -131,7 +131,7 @@ func foo() {
good() //nolint: linter1, linter2
}`,
expected: []issueWithReplacement{
- {issue: "directive `//nolint:linter1 linter2` should match `//nolint[:<comma-separated-linters>] [// <explanation>]` at testing.go:6:9"}, //nolint:lll // this is a string
+ {issue: "directive `//nolint:linter1 linter2` should match `//nolint[:<comma-separated-linters>] [// <explanation>]` at testing.go:6:9"},
},
},
{
diff --git a/pkg/golinters/prealloc.go b/pkg/golinters/prealloc.go
index f48d5756..47776149 100644
--- a/pkg/golinters/prealloc.go
+++ b/pkg/golinters/prealloc.go
@@ -15,7 +15,6 @@ import (
const preallocName = "prealloc"
-//nolint:dupl
func NewPreAlloc(settings *config.PreallocSettings) *goanalysis.Linter {
var mu sync.Mutex
var resIssues []goanalysis.Issue
diff --git a/pkg/golinters/unconvert.go b/pkg/golinters/unconvert.go
index 5f8c7318..08e493ae 100644
--- a/pkg/golinters/unconvert.go
+++ b/pkg/golinters/unconvert.go
@@ -14,7 +14,6 @@ import (
const unconvertName = "unconvert"
-//nolint:dupl // This is not a duplicate of dogsled.
func NewUnconvert(settings *config.UnconvertSettings) *goanalysis.Linter {
var mu sync.Mutex
var resIssues []goanalysis.Issue
diff --git a/pkg/logutils/stderr_log.go b/pkg/logutils/stderr_log.go
index 367c94f3..569a177a 100644
--- a/pkg/logutils/stderr_log.go
+++ b/pkg/logutils/stderr_log.go
@@ -5,7 +5,7 @@ import (
"os"
"time"
- "github.com/sirupsen/logrus" //nolint:depguard
+ "github.com/sirupsen/logrus"
"github.com/golangci/golangci-lint/pkg/exitcodes"
)
diff --git a/pkg/packages/util_test.go b/pkg/packages/util_test.go
index 89584b7f..53084299 100644
--- a/pkg/packages/util_test.go
+++ b/pkg/packages/util_test.go
@@ -6,7 +6,6 @@ import (
"github.com/stretchr/testify/assert"
)
-//nolint:lll
func Test_stackCrusher(t *testing.T) {
testCases := []struct {
desc string
diff --git a/pkg/printers/checkstyle_test.go b/pkg/printers/checkstyle_test.go
index cf8a7d81..9c269131 100644
--- a/pkg/printers/checkstyle_test.go
+++ b/pkg/printers/checkstyle_test.go
@@ -49,7 +49,6 @@ func TestCheckstyle_Print(t *testing.T) {
err := printer.Print(issues)
require.NoError(t, err)
- //nolint:lll
expected := "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n\n<checkstyle version=\"5.0\">\n <file name=\"path/to/filea.go\">\n <error column=\"4\" line=\"10\" message=\"some issue\" severity=\"warning\" source=\"linter-a\"></error>\n </file>\n <file name=\"path/to/fileb.go\">\n <error column=\"9\" line=\"300\" message=\"another issue\" severity=\"error\" source=\"linter-b\"></error>\n </file>\n</checkstyle>\n"
assert.Equal(t, expected, strings.ReplaceAll(buf.String(), "\r", ""))
diff --git a/pkg/printers/codeclimate_test.go b/pkg/printers/codeclimate_test.go
index 6ee9f1cf..37c4d21b 100644
--- a/pkg/printers/codeclimate_test.go
+++ b/pkg/printers/codeclimate_test.go
@@ -63,7 +63,6 @@ func TestCodeClimate_Print(t *testing.T) {
err := printer.Print(issues)
require.NoError(t, err)
- //nolint:lll
expected := `[{"description":"linter-a: some issue","severity":"warning","fingerprint":"BA73C5DF4A6FD8462FFF1D3140235777","location":{"path":"path/to/filea.go","lines":{"begin":10}}},{"description":"linter-b: another issue","severity":"error","fingerprint":"0777B4FE60242BD8B2E9B7E92C4B9521","location":{"path":"path/to/fileb.go","lines":{"begin":300}}},{"description":"linter-c: issue c","severity":"critical","fingerprint":"BEE6E9FBB6BFA4B7DB9FB036697FB036","location":{"path":"path/to/filec.go","lines":{"begin":200}}}]
`
diff --git a/pkg/printers/github_test.go b/pkg/printers/github_test.go
index d927ddd2..c6abd2de 100644
--- a/pkg/printers/github_test.go
+++ b/pkg/printers/github_test.go
@@ -1,4 +1,3 @@
-//nolint:dupl
package printers
import (
diff --git a/pkg/printers/html_test.go b/pkg/printers/html_test.go
index 23d479ca..9adf42a2 100644
--- a/pkg/printers/html_test.go
+++ b/pkg/printers/html_test.go
@@ -11,7 +11,6 @@ import (
"github.com/golangci/golangci-lint/pkg/result"
)
-//nolint:lll
const expectedHTML = `<!doctype html>
<html lang="en">
<head>
diff --git a/pkg/printers/json_test.go b/pkg/printers/json_test.go
index 78111d9b..98d21e90 100644
--- a/pkg/printers/json_test.go
+++ b/pkg/printers/json_test.go
@@ -49,7 +49,6 @@ func TestJSON_Print(t *testing.T) {
err := printer.Print(issues)
require.NoError(t, err)
- //nolint:lll
expected := `{"Issues":[{"FromLinter":"linter-a","Text":"some issue","Severity":"warning","SourceLines":null,"Replacement":null,"Pos":{"Filename":"path/to/filea.go","Offset":2,"Line":10,"Column":4},"ExpectNoLint":false,"ExpectedNoLintLinter":""},{"FromLinter":"linter-b","Text":"another issue","Severity":"error","SourceLines":["func foo() {","\tfmt.Println(\"bar\")","}"],"Replacement":null,"Pos":{"Filename":"path/to/fileb.go","Offset":5,"Line":300,"Column":9},"ExpectNoLint":false,"ExpectedNoLintLinter":""}],"Report":null}
`
diff --git a/pkg/printers/junitxml_test.go b/pkg/printers/junitxml_test.go
index c10d6403..d5b4bc1f 100644
--- a/pkg/printers/junitxml_test.go
+++ b/pkg/printers/junitxml_test.go
@@ -1,4 +1,3 @@
-//nolint:dupl
package printers
import (
diff --git a/pkg/printers/tab_test.go b/pkg/printers/tab_test.go
index bbd529b0..00e376ef 100644
--- a/pkg/printers/tab_test.go
+++ b/pkg/printers/tab_test.go
@@ -77,8 +77,7 @@ path/to/fileb.go:300:9 another issue
desc: "enable all options",
printLinterName: true,
useColors: true,
- //nolint:lll // color characters must be in a simple string.
- expected: "\x1b[1mpath/to/filea.go:10\x1b[22m:4 linter-a \x1b[31msome issue\x1b[0m\n\x1b[1mpath/to/fileb.go:300\x1b[22m:9 linter-b \x1b[31manother issue\x1b[0m\n",
+ expected: "\x1b[1mpath/to/filea.go:10\x1b[22m:4 linter-a \x1b[31msome issue\x1b[0m\n\x1b[1mpath/to/fileb.go:300\x1b[22m:9 linter-b \x1b[31manother issue\x1b[0m\n",
},
}
diff --git a/pkg/printers/text_test.go b/pkg/printers/text_test.go
index f7531349..fe9c5309 100644
--- a/pkg/printers/text_test.go
+++ b/pkg/printers/text_test.go
@@ -96,8 +96,7 @@ func foo() {
printIssuedLine: true,
printLinterName: true,
useColors: true,
- //nolint:lll // color characters must be in a simple string.
- expected: "\x1b[1mpath/to/filea.go:10\x1b[22m:4: \x1b[31msome issue\x1b[0m (linter-a)\n\x1b[1mpath/to/fileb.go:300\x1b[22m:9: \x1b[31manother issue\x1b[0m (linter-b)\nfunc foo() {\n\tfmt.Println(\"bar\")\n}\n",
+ expected: "\x1b[1mpath/to/filea.go:10\x1b[22m:4: \x1b[31msome issue\x1b[0m (linter-a)\n\x1b[1mpath/to/fileb.go:300\x1b[22m:9: \x1b[31manother issue\x1b[0m (linter-b)\nfunc foo() {\n\tfmt.Println(\"bar\")\n}\n",
},
{
desc: "disable all options",
diff --git a/pkg/result/issue.go b/pkg/result/issue.go
index 1e8cd305..32246a6d 100644
--- a/pkg/result/issue.go
+++ b/pkg/result/issue.go
@@ -1,7 +1,7 @@
package result
import (
- "crypto/md5" //nolint:gosec
+ "crypto/md5" //nolint:gosec // for md5 hash
"fmt"
"go/token"
@@ -91,7 +91,7 @@ func (i *Issue) Fingerprint() string {
firstLine = i.SourceLines[0]
}
- hash := md5.New() //nolint:gosec
+ hash := md5.New() //nolint:gosec // we don't need a strong hash here
_, _ = fmt.Fprintf(hash, "%s%s%s", i.Pos.Filename, i.Text, firstLine)
return fmt.Sprintf("%X", hash.Sum(nil))
diff --git a/pkg/result/processors/base_rule.go b/pkg/result/processors/base_rule.go
index 88140bfa..12333c89 100644
--- a/pkg/result/processors/base_rule.go
+++ b/pkg/result/processors/base_rule.go
@@ -65,7 +65,7 @@ func (r *baseRule) matchLinter(issue *result.Issue) bool {
return false
}
-func (r *baseRule) matchSource(issue *result.Issue, lineCache *fsutils.LineCache, log logutils.Log) bool { //nolint:interfacer
+func (r *baseRule) matchSource(issue *result.Issue, lineCache *fsutils.LineCache, log logutils.Log) bool {
sourceLine, errSourceLine := lineCache.GetLine(issue.FilePath(), issue.Line())
if errSourceLine != nil {
log.Warnf("Failed to get line %s:%d from line cache: %s", issue.FilePath(), issue.Line(), errSourceLine)
diff --git a/pkg/result/processors/exclude_rules_test.go b/pkg/result/processors/exclude_rules_test.go
index 96f6788e..05782a44 100644
--- a/pkg/result/processors/exclude_rules_test.go
+++ b/pkg/result/processors/exclude_rules_test.go
@@ -50,7 +50,6 @@ func TestExcludeRules_multiple(t *testing.T) {
p := NewExcludeRules(nil, files, opts)
- //nolint:dupl
cases := []issueTestCase{
{Path: "e.go", Text: "exclude", Linter: "linter"},
{Path: "e.go", Text: "some", Linter: "linter"},
@@ -210,7 +209,6 @@ func TestExcludeRules_caseSensitive_multiple(t *testing.T) {
p := NewExcludeRules(nil, files, opts)
- //nolint:dupl
cases := []issueTestCase{
{Path: "e.go", Text: "exclude", Linter: "linter"},
{Path: "e.go", Text: "excLude", Linter: "linter"},
diff --git a/pkg/result/processors/fixer.go b/pkg/result/processors/fixer.go
index 5c6d12ac..2879beb4 100644
--- a/pkg/result/processors/fixer.go
+++ b/pkg/result/processors/fixer.go
@@ -164,7 +164,7 @@ func (f Fixer) applyInlineFixes(lineIssues []result.Issue, origLine []byte, line
var newLineBuf bytes.Buffer
newLineBuf.Grow(len(origLine))
- //nolint:misspell
+ //nolint:misspell // misspelling is intentional
// example: origLine="it's becouse of them", StartCol=5, Length=7, NewString="because"
curOrigLinePos := 0
diff --git a/pkg/result/processors/identifier_marker_test.go b/pkg/result/processors/identifier_marker_test.go
index bef3f06a..beafab90 100644
--- a/pkg/result/processors/identifier_marker_test.go
+++ b/pkg/result/processors/identifier_marker_test.go
@@ -10,7 +10,6 @@ import (
)
func TestIdentifierMarker(t *testing.T) {
- //nolint:lll
cases := []struct{ in, out string }{
{"unknown field Address in struct literal", "unknown field `Address` in struct literal"},
{
diff --git a/pkg/result/processors/sort_results_test.go b/pkg/result/processors/sort_results_test.go
index c75b0bbe..46e8e76f 100644
--- a/pkg/result/processors/sort_results_test.go
+++ b/pkg/result/processors/sort_results_test.go
@@ -104,7 +104,7 @@ func TestCompareByLine(t *testing.T) {
})
}
-func TestCompareByFileName(t *testing.T) { //nolint:dupl
+func TestCompareByFileName(t *testing.T) {
testCompareValues(t, byFileName(), "Compare By File Name", []compareTestCase{
{issues[0], issues[1], greater}, // file_windows.go vs file_linux.go
{issues[1], issues[2], greater}, // file_linux.go vs file_darwin.go
@@ -119,7 +119,7 @@ func TestCompareByFileName(t *testing.T) { //nolint:dupl
})
}
-func TestCompareByColumn(t *testing.T) { //nolint:dupl
+func TestCompareByColumn(t *testing.T) {
testCompareValues(t, byColumn(), "Compare By Column", []compareTestCase{
{issues[0], issues[1], greater}, // 80 vs 70
{issues[1], issues[2], none}, // 70 vs zero value
@@ -134,7 +134,7 @@ func TestCompareByColumn(t *testing.T) { //nolint:dupl
})
}
-func TestCompareByLinter(t *testing.T) { //nolint:dupl
+func TestCompareByLinter(t *testing.T) {
testCompareValues(t, byLinter(), "Compare By Linter", []compareTestCase{
{issues[0], issues[1], greater}, // b vs a
{issues[1], issues[2], less}, // a vs c
diff --git a/scripts/website/expand_templates/main.go b/scripts/website/expand_templates/main.go
index e2951f3f..211a9a29 100644
--- a/scripts/website/expand_templates/main.go
+++ b/scripts/website/expand_templates/main.go
@@ -96,7 +96,7 @@ type latestRelease struct {
func getLatestVersion() (string, error) {
endpoint := "https://api.github.com/repos/golangci/golangci-lint/releases/latest"
- //nolint:noctx
+ //nolint:noctx // request timeout handled by the client
req, err := http.NewRequest(http.MethodGet, endpoint, http.NoBody)
if err != nil {
return "", fmt.Errorf("prepare a HTTP request: %w", err)
diff --git a/test/output_test.go b/test/output_test.go
index fba1bede..e3c3b71e 100644
--- a/test/output_test.go
+++ b/test/output_test.go
@@ -12,7 +12,7 @@ import (
"github.com/golangci/golangci-lint/test/testshared"
)
-//nolint:misspell,lll
+//nolint:misspell // misspelling is intentional
const expectedJSONOutput = `{"Issues":[{"FromLinter":"misspell","Text":"` + "`" + `occured` + "`" + ` is a misspelling of ` + "`" + `occurred` + "`" + `","Severity":"","SourceLines":["\t// comment with incorrect spelling: occured // want \"` + "`" + `occured` + "`" + ` is a misspelling of ` + "`" + `occurred` + "`" + `\""],"Replacement":{"NeedOnlyDelete":false,"NewLines":null,"Inline":{"StartCol":37,"Length":7,"NewString":"occurred"}},"Pos":{"Filename":"testdata/misspell.go","Offset":0,"Line":6,"Column":38},"ExpectNoLint":false,"ExpectedNoLintLinter":""}]`
func TestOutput_lineNumber(t *testing.T) {
@@ -30,7 +30,7 @@ func TestOutput_lineNumber(t *testing.T) {
Runner().
Install().
Run().
- //nolint:misspell
+ //nolint:misspell // misspelling is intentional
ExpectHasIssue("testdata/misspell.go:6:38: `occured` is a misspelling of `occurred`")
}
@@ -91,7 +91,7 @@ func TestOutput_Multiple(t *testing.T) {
Runner().
Install().
Run().
- //nolint:misspell
+ //nolint:misspell // misspelling is intentional
ExpectHasIssue("testdata/misspell.go:6:38: `occured` is a misspelling of `occurred`").
ExpectOutputContains(testshared.NormalizeFilePathInJSON(expectedJSONOutput))
}
diff --git a/test/testshared/directives.go b/test/testshared/directives.go
index 34f37daf..2881816b 100644
--- a/test/testshared/directives.go
+++ b/test/testshared/directives.go
@@ -25,7 +25,7 @@ type RunContext struct {
// ParseTestDirectives parses test directives from sources files.
//
-//nolint:gocyclo,funlen
+//nolint:funlen,gocyclo // can't be simplified without losing readability
func ParseTestDirectives(tb testing.TB, sourcePath string) *RunContext {
tb.Helper()
@@ -108,7 +108,9 @@ func ParseTestDirectives(tb testing.TB, sourcePath string) *RunContext {
if rc.ExpectedLinter == "" {
for _, arg := range rc.Args {
if strings.HasPrefix(arg, "-E") && !strings.Contains(arg, ",") {
- require.Empty(tb, rc.ExpectedLinter, "could not infer expected linter for errors because multiple linters are enabled. Please use the `//golangcitest:expected_linter ` directive in your test to indicate the linter-under-test.") //nolint:lll
+ require.Empty(tb, rc.ExpectedLinter,
+ "could not infer expected linter for errors because multiple linters are enabled. "+
+ "Please use the `//golangcitest:expected_linter ` directive in your test to indicate the linter-under-test.")
rc.ExpectedLinter = arg[2:]
}
}
diff --git a/test/testshared/runner.go b/test/testshared/runner.go
index 0be6d740..f1f2adcb 100644
--- a/test/testshared/runner.go
+++ b/test/testshared/runner.go
@@ -267,7 +267,7 @@ func (r *Runner) Command() *exec.Cmd {
runArgs := append([]string{r.command}, r.args...)
- //nolint:gosec
+ //nolint:gosec // we don't use user input here
cmd := exec.Command(r.binPath, runArgs...)
cmd.Env = append(os.Environ(), r.env...)