eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Support disable rule when enable-all is true

Browse Source 
Similar to the behavior of command line flags:
enable-all to enable existing linters then disable unwanted ones.
But for vet rules.
This commit is contained in:
ferhat elmas 2020-03-11 17:20:25 +01:00
parent 76a82c6ed1
commit 4d367808be
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/golinters/govet.go
View File

@ -101,6 +101,11 @@ var (
func isAnalyzerEnabled(name string, cfg *config.GovetSettings, defaultAnalyzers []*analysis.Analyzer) bool { func isAnalyzerEnabled(name string, cfg *config.GovetSettings, defaultAnalyzers []*analysis.Analyzer) bool {
if cfg.EnableAll { if cfg.EnableAll {
for _, n := range cfg.Disable {
if n == name {
return false
}
}
return true return true
} }
// Raw for loops should be OK on small slice lengths. // Raw for loops should be OK on small slice lengths.

1
pkg/golinters/govet_test.go
View File

@ -79,6 +79,7 @@ func TestGovetAnalyzerIsEnabled(t *testing.T) {
{Name: "bools", Enabled: false, Disable: []string{"bools"}}, {Name: "bools", Enabled: false, Disable: []string{"bools"}},
{Name: "unsafeptr", Enabled: true, Enable: []string{"unsafeptr"}}, {Name: "unsafeptr", Enabled: true, Enable: []string{"unsafeptr"}},
{Name: "shift", Enabled: true, EnableAll: true}, {Name: "shift", Enabled: true, EnableAll: true},
{Name: "shadow", EnableAll: true, Disable: []string{"shadow"}, Enabled: false},
} { } {
cfg := &config.GovetSettings{ cfg := &config.GovetSettings{
Enable: tc.Enable, Enable: tc.Enable,