errcheck: empty selector name. (#2309)

This commit is contained in:
Ludovic Fernandez 2021-10-25 15:04:13 +02:00 committed by GitHub
parent bdc2f96de9
commit 413bec6a4d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -66,9 +66,14 @@ func NewErrcheck() *goanalysis.Linter {
for i, err := range errcheckIssues.UncheckedErrors { for i, err := range errcheckIssues.UncheckedErrors {
var text string var text string
if err.FuncName != "" { if err.FuncName != "" {
code := err.SelectorName
if err.SelectorName == "" {
code = err.FuncName
}
text = fmt.Sprintf( text = fmt.Sprintf(
"Error return value of %s is not checked", "Error return value of %s is not checked",
formatCode(err.SelectorName, lintCtx.Cfg), formatCode(code, lintCtx.Cfg),
) )
} else { } else {
text = "Error return value is not checked" text = "Error return value is not checked"