From 40d7bcd53e3b69e0e7c6f6f7881db1f72edf3c5f Mon Sep 17 00:00:00 2001 From: Denis Isaev Date: Sun, 19 Jan 2020 16:19:23 +0300 Subject: [PATCH] Fix after #890: don't propagate linter errors for golangci.com --- pkg/lint/runner.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/lint/runner.go b/pkg/lint/runner.go index d42d1708..56b02cce 100644 --- a/pkg/lint/runner.go +++ b/pkg/lint/runner.go @@ -3,6 +3,7 @@ package lint import ( "context" "fmt" + "os" "runtime/debug" "strings" @@ -187,7 +188,10 @@ func (r Runner) Run(ctx context.Context, linters []*linter.Config, lintCtx *lint linterIssues, err := r.runLinterSafe(ctx, lintCtx, lc) if err != nil { r.Log.Warnf("Can't run linter %s: %s", lc.Linter.Name(), err) - runErr = err + if os.Getenv("GOLANGCI_COM_RUN") == "" { + // Don't stop all linters on one linter failure for golangci.com. + runErr = err + } return } issues = append(issues, linterIssues...)