eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

unused: check line range before suggesting fix

Browse Source 
Fix #1048
This commit is contained in:
Aleksandr Razumov 2020-04-27 19:56:45 +03:00
parent 1353b60074
commit 3deb9d80ab
No known key found for this signature in database
GPG Key ID: 1D14A82D2E311045
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/golinters/unused.go
View File

@ -33,7 +33,7 @@ func NewUnused() *goanalysis.Linter {
for _, ur := range u.Result() { for _, ur := range u.Result() {
p := u.ProblemObject(lintCtx.Packages[0].Fset, ur) p := u.ProblemObject(lintCtx.Packages[0].Fset, ur)
pkg := typesToPkg[ur.Pkg()] pkg := typesToPkg[ur.Pkg()]
issues = append(issues, goanalysis.NewIssue(&result.Issue{ //nolint:scopelint i := &result.Issue{
FromLinter: name, FromLinter: name,
Text: p.Message, Text: p.Message,
Pos: p.Pos, Pos: p.Pos,
@ -42,11 +42,16 @@ func NewUnused() *goanalysis.Linter {
From: p.Pos.Line, From: p.Pos.Line,
To: p.End.Line, To: p.End.Line,
}, },
Replacement: &result.Replacement{ }
// See https://github.com/golangci/golangci-lint/issues/1048
// If range is invalid, this will break `--fix` mode.
if i.LineRange.To >= i.LineRange.From {
i.Replacement = &result.Replacement{
// Suggest deleting unused stuff. // Suggest deleting unused stuff.
NeedOnlyDelete: true, NeedOnlyDelete: true,
}, }
}, nil)) }
issues = append(issues, goanalysis.NewIssue(i, nil))
} }
return issues return issues
}).WithContextSetter(func(lintCtx *linter.Context) { }).WithContextSetter(func(lintCtx *linter.Context) {