eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

fix invalid error message "no go files to analyze" (#1154)

Browse Source 
In case of timeouts of go/packages loading
we could return such error.

Relates: #825
This commit is contained in:
Isaev Denis 2020-05-19 09:55:25 +03:00 committed by GitHub
parent 54f83ae521
commit 3c46e160de
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/lint/load.go
View File

@ -199,7 +199,14 @@ func (cl *ContextLoader) loadPackages(ctx context.Context, loadMode packages.Loa
cl.debugf("Built loader args are %s", args) cl.debugf("Built loader args are %s", args)
pkgs, err := packages.Load(conf, args...) pkgs, err := packages.Load(conf, args...)
if err != nil { if err != nil {
return nil, errors.Wrap(err, "failed to load program with go/packages") return nil, errors.Wrap(err, "failed to load with go/packages")
}
// Currently, go/packages doesn't guarantee that error will be returned
// if context was canceled. See
// https://github.com/golang/tools/commit/c5cec6710e927457c3c29d6c156415e8539a5111#r39261855
if ctx.Err() != nil {
return nil, errors.Wrap(ctx.Err(), "timed out to load packages")
} }
if loadMode&packages.NeedSyntax == 0 { if loadMode&packages.NeedSyntax == 0 {
@ -280,7 +287,7 @@ func (cl *ContextLoader) Load(ctx context.Context, linters []*linter.Config) (*l
loadMode := cl.findLoadMode(linters) loadMode := cl.findLoadMode(linters)
pkgs, err := cl.loadPackages(ctx, loadMode) pkgs, err := cl.loadPackages(ctx, loadMode)
if err != nil { if err != nil {
return nil, err return nil, errors.Wrap(err, "failed to load packages")
} }
deduplicatedPkgs := cl.filterDuplicatePackages(pkgs) deduplicatedPkgs := cl.filterDuplicatePackages(pkgs)