eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Merge pull request #10 from golangci/feature/add-column-and-disable-welcome-message

Browse Source 
add column of issue line; disable welcome message by default
This commit is contained in:
golangci 2018-05-26 09:50:35 +03:00 committed by GitHub
commit 35f2cc3d39
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/commands/run.go
View File

@ -45,7 +45,7 @@ func (e *Executor) initRun() {
fmt.Sprintf("Format of output: %s", strings.Join(config.OutFormats, "|"))) fmt.Sprintf("Format of output: %s", strings.Join(config.OutFormats, "|")))
runCmd.Flags().BoolVar(&oc.PrintIssuedLine, "print-issued-lines", true, "Print lines of code with issue") runCmd.Flags().BoolVar(&oc.PrintIssuedLine, "print-issued-lines", true, "Print lines of code with issue")
runCmd.Flags().BoolVar(&oc.PrintLinterName, "print-linter-name", true, "Print linter name in issue line") runCmd.Flags().BoolVar(&oc.PrintLinterName, "print-linter-name", true, "Print linter name in issue line")
runCmd.Flags().BoolVar(&oc.PrintWelcomeMessage, "print-welcome", true, "Print welcome message") runCmd.Flags().BoolVar(&oc.PrintWelcomeMessage, "print-welcome", false, "Print welcome message")
// Run config // Run config
rc := &e.cfg.Run rc := &e.cfg.Run

3
pkg/printers/text.go
View File

@ -102,6 +102,9 @@ func (p Text) printIssue(i *result.Issue) {
text += fmt.Sprintf(" (%s)", i.FromLinter) text += fmt.Sprintf(" (%s)", i.FromLinter)
} }
pos := p.SprintfColored(color.Bold, "%s:%d", i.FilePath(), i.Line()) pos := p.SprintfColored(color.Bold, "%s:%d", i.FilePath(), i.Line())
if i.Pos.Column != 0 {
pos += fmt.Sprintf(":%d", i.Pos.Column)
}
fmt.Fprintf(stdOut, "%s: %s\n", pos, text) fmt.Fprintf(stdOut, "%s: %s\n", pos, text)
} }