eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Update wastedassign to v2.0.6 (#2020)

Browse Source 
* Update: wastedassign to v2.0.5

* Update: wastedassign to v2.0.6
This commit is contained in:
Kensei Nakada 2021-05-29 20:26:26 +09:00 committed by GitHub
parent 7776b546b8
commit 2dcc761d21
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
go.mod
View File

@ -60,7 +60,7 @@ require (
github.com/polyfloyd/go-errorlint v0.0.0-20210510181950-ab96adb96fea github.com/polyfloyd/go-errorlint v0.0.0-20210510181950-ab96adb96fea
github.com/ryancurrah/gomodguard v1.2.1 github.com/ryancurrah/gomodguard v1.2.1
github.com/ryanrolds/sqlclosecheck v0.3.0 github.com/ryanrolds/sqlclosecheck v0.3.0
github.com/sanposhiho/wastedassign v1.0.0 github.com/sanposhiho/wastedassign/v2 v2.0.6
github.com/securego/gosec/v2 v2.7.0 github.com/securego/gosec/v2 v2.7.0
github.com/shazow/go-diff v0.0.0-20160112020656-b6b7b6733b8c github.com/shazow/go-diff v0.0.0-20160112020656-b6b7b6733b8c
github.com/shirou/gopsutil/v3 v3.21.4 github.com/shirou/gopsutil/v3 v3.21.4

4
go.sum generated
View File

@ -544,8 +544,8 @@ github.com/ryancurrah/gomodguard v1.2.1/go.mod h1:tpI+C/nzvfUR3bF28b5QHpTn/jM/zl
github.com/ryanrolds/sqlclosecheck v0.3.0 h1:AZx+Bixh8zdUBxUA1NxbxVAS78vTPq4rCb8OUZI9xFw= github.com/ryanrolds/sqlclosecheck v0.3.0 h1:AZx+Bixh8zdUBxUA1NxbxVAS78vTPq4rCb8OUZI9xFw=
github.com/ryanrolds/sqlclosecheck v0.3.0/go.mod h1:1gREqxyTGR3lVtpngyFo3hZAgk0KCtEdgEkHwDbigdA= github.com/ryanrolds/sqlclosecheck v0.3.0/go.mod h1:1gREqxyTGR3lVtpngyFo3hZAgk0KCtEdgEkHwDbigdA=
github.com/ryanuber/columnize v0.0.0-20160712163229-9b3edd62028f/go.mod h1:sm1tb6uqfes/u+d4ooFouqFdy9/2g9QGwK3SQygK0Ts= github.com/ryanuber/columnize v0.0.0-20160712163229-9b3edd62028f/go.mod h1:sm1tb6uqfes/u+d4ooFouqFdy9/2g9QGwK3SQygK0Ts=
github.com/sanposhiho/wastedassign v1.0.0 h1:dB+7OV0iJ5b0SpGwKjKlPCr8GDZJX6Ylm3YG+66xGpc= github.com/sanposhiho/wastedassign/v2 v2.0.6 h1:+6/hQIHKNJAUixEj6EmOngGIisyeI+T3335lYTyxRoA=
github.com/sanposhiho/wastedassign v1.0.0/go.mod h1:LGpq5Hsv74QaqM47WtIsRSF/ik9kqk07kchgv66tLVE= github.com/sanposhiho/wastedassign/v2 v2.0.6/go.mod h1:KyZ0MWTwxxBmfwn33zh3k1dmsbF2ud9pAAGfoLfjhtI=
github.com/sean-/seed v0.0.0-20170313163322-e2103e2c3529/go.mod h1:DxrIzT+xaE7yg65j358z/aeFdxmN0P9QXhEzd20vsDc= github.com/sean-/seed v0.0.0-20170313163322-e2103e2c3529/go.mod h1:DxrIzT+xaE7yg65j358z/aeFdxmN0P9QXhEzd20vsDc=
github.com/securego/gosec/v2 v2.7.0 h1:mOhJv5w6UyNLpSssQOQCc7eGkKLuicAxvf66Ey/X4xk= github.com/securego/gosec/v2 v2.7.0 h1:mOhJv5w6UyNLpSssQOQCc7eGkKLuicAxvf66Ey/X4xk=
github.com/securego/gosec/v2 v2.7.0/go.mod h1:xNbGArrGUspJLuz3LS5XCY1EBW/0vABAl/LWfSklmiM= github.com/securego/gosec/v2 v2.7.0/go.mod h1:xNbGArrGUspJLuz3LS5XCY1EBW/0vABAl/LWfSklmiM=

2
pkg/golinters/wastedassign.go
View File

@ -1,7 +1,7 @@
package golinters package golinters
import ( import (
"github.com/sanposhiho/wastedassign" "github.com/sanposhiho/wastedassign/v2"
"golang.org/x/tools/go/analysis" "golang.org/x/tools/go/analysis"
"github.com/golangci/golangci-lint/pkg/golinters/goanalysis" "github.com/golangci/golangci-lint/pkg/golinters/goanalysis"

28
test/testdata/wastedassign.go vendored
View File

@ -27,28 +27,28 @@ func noUseParams(params string) int {
func f(param int) int { func f(param int) int {
println(param) println(param)
useOutOfIf := 1212121 // ERROR "assigned, but reassigned without using the value" useOutOfIf := 1212121 // ERROR "assigned to useOutOfIf, but reassigned without using the value"
ret := 0 ret := 0
if false { if false {
useOutOfIf = 200 // ERROR "assigned, but never used afterwards" useOutOfIf = 200 // ERROR "assigned to useOutOfIf, but never used afterwards"
return 0 return 0
} else if param == 100 { } else if param == 100 {
useOutOfIf = 100 // ERROR "assigned, but reassigned without using the value" useOutOfIf = 100 // ERROR "assigned to useOutOfIf, but reassigned without using the value"
useOutOfIf = 201 useOutOfIf = 201
useOutOfIf = pa(useOutOfIf) useOutOfIf = pa(useOutOfIf)
useOutOfIf += 200 // ERROR "assigned, but reassigned without using the value" useOutOfIf += 200 // ERROR "assigned to useOutOfIf, but reassigned without using the value"
} else { } else {
useOutOfIf = 100 useOutOfIf = 100
useOutOfIf += 100 useOutOfIf += 100
useOutOfIf = pa(useOutOfIf) useOutOfIf = pa(useOutOfIf)
useOutOfIf += 200 // ERROR "assigned, but reassigned without using the value" useOutOfIf += 200 // ERROR "assigned to useOutOfIf, but reassigned without using the value"
} }
if false { if false {
useOutOfIf = 200 // ERROR "assigned, but never used afterwards" useOutOfIf = 200 // ERROR "assigned to useOutOfIf, but never used afterwards"
return 0 return 0
} else if param == 200 { } else if param == 200 {
useOutOfIf = 100 // ERROR "assigned, but reassigned without using the value" useOutOfIf = 100 // ERROR "assigned to useOutOfIf, but reassigned without using the value"
useOutOfIf = 201 useOutOfIf = 201
useOutOfIf = pa(useOutOfIf) useOutOfIf = pa(useOutOfIf)
useOutOfIf += 200 useOutOfIf += 200
@ -62,7 +62,7 @@ func f(param int) int {
println(useOutOfIf) println(useOutOfIf)
useOutOfIf = 192 useOutOfIf = 192
useOutOfIf += 100 useOutOfIf += 100
useOutOfIf += 200 // ERROR "assigned, but never used afterwards" useOutOfIf += 200 // ERROR "assigned to useOutOfIf, but never used afterwards"
return ret return ret
} }
@ -71,7 +71,7 @@ func checkLoopTest() int {
noUse := 1111 noUse := 1111
println(noUse) println(noUse)
noUse = 1111 // ERROR "assigned, but never used afterwards" noUse = 1111 // ERROR "assigned to noUse, but never used afterwards"
for { for {
if hoge == 14 { if hoge == 14 {
break break
@ -86,21 +86,21 @@ func r(param int) int {
useOutOfIf := 1212121 useOutOfIf := 1212121
ret := 0 ret := 0
if false { if false {
useOutOfIf = 200 // ERROR "assigned, but never used afterwards" useOutOfIf = 200 // ERROR "assigned to useOutOfIf, but never used afterwards"
return 0 return 0
} else if param == 100 { } else if param == 100 {
ret = useOutOfIf ret = useOutOfIf
} else if param == 200 { } else if param == 200 {
useOutOfIf = 100 // ERROR "assigned, but reassigned without using the value" useOutOfIf = 100 // ERROR "assigned to useOutOfIf, but reassigned without using the value"
useOutOfIf = 100 useOutOfIf = 100
useOutOfIf = pa(useOutOfIf) useOutOfIf = pa(useOutOfIf)
useOutOfIf += 200 // ERROR "assigned, but reassigned without using the value" useOutOfIf += 200 // ERROR "assigned to useOutOfIf, but reassigned without using the value"
} }
useOutOfIf = 12 useOutOfIf = 12
println(useOutOfIf) println(useOutOfIf)
useOutOfIf = 192 useOutOfIf = 192
useOutOfIf += 100 useOutOfIf += 100
useOutOfIf += 200 // ERROR "assigned, but never used afterwards" useOutOfIf += 200 // ERROR "assigned to useOutOfIf, but never used afterwards"
return ret return ret
} }
@ -108,7 +108,7 @@ func mugen() {
var i int var i int
var hoge int var hoge int
for { for {
hoge = 5 // ERROR "assigned, but reassigned without using the value" hoge = 5 // ERROR "assigned to hoge, but reassigned without using the value"
// break // break
} }