eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Fix #318: better validate linters and help commands

Browse Source
This commit is contained in:
Denis Isaev 2018-12-22 15:55:53 +03:00
parent a4a7100011
commit 21c2590ba8
No known key found for this signature in database
GPG Key ID: A36A0EC8E27A1A01
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/commands/help.go
View File

@ -44,6 +44,10 @@ func printLinterConfigs(lcs []linter.Config) {
} }
func (e Executor) executeLintersHelp(cmd *cobra.Command, args []string) { func (e Executor) executeLintersHelp(cmd *cobra.Command, args []string) {
if len(args) != 0 {
e.log.Fatalf("Usage: golangci-lint help linters")
}
var enabledLCs, disabledLCs []linter.Config var enabledLCs, disabledLCs []linter.Config
for _, lc := range e.DBManager.GetAllSupportedLinterConfigs() { for _, lc := range e.DBManager.GetAllSupportedLinterConfigs() {
if lc.EnabledByDefault { if lc.EnabledByDefault {

4
pkg/commands/linters.go
View File

@ -31,6 +31,10 @@ func IsLinterInConfigsList(name string, linters []linter.Config) bool {
} }
func (e *Executor) executeLinters(cmd *cobra.Command, args []string) { func (e *Executor) executeLinters(cmd *cobra.Command, args []string) {
if len(args) != 0 {
e.log.Fatalf("Usage: golangci-lint linters")
}
enabledLCs, err := e.EnabledLintersSet.Get() enabledLCs, err := e.EnabledLintersSet.Get()
if err != nil { if err != nil {
log.Fatalf("Can't get enabled linters: %s", err) log.Fatalf("Can't get enabled linters: %s", err)